Fix lack of success messages printing

diff --git a/doc/news.texi b/doc/news.texi
index a07870bab4e14736add62970e1035c1662e50e4d..b00f197ac580138ac38c09bcb73970be6520d51c 100644 (file)
--- a/doc/news.texi
+++ b/doc/news.texi
@@ -1,6 +1,14 @@
 @node News
 @unnumbered News
 
+@anchor{Release 1_12_0}
+@section Release 1.12.0
+@itemize
+@item
+    Fix possible lack of success finish message printing if any of
+    targets fail.
+@end itemize
+
 @anchor{Release 1_11_0}
 @section Release 1.11.0
 @itemize

diff --git a/ifchange.go b/ifchange.go
index 3a0ebf395211943178ea72d5442a71c4e6bd6408..128d1afbef6eaea5fdd1681af86cb1339ec8f738 100644 (file)
--- a/ifchange.go
+++ b/ifchange.go
@@ -116,7 +116,7 @@ func buildDependants(tgts []string) map[string]struct{} {
        }
        ok := true
        for i := 0; i < len(seen); i++ {
-               ok = ok && isOkRun(<-errs)
+               ok = isOkRun(<-errs) && ok
        }
        Jobs.Wait()
        close(errs)
@@ -163,7 +163,7 @@ RebuildDeps:
                jobs++
        }
        for i := 0; i < jobs; i++ {
-               ok = ok && isOkRun(<-errs)
+               ok = isOkRun(<-errs) && ok
        }
        if !ok {
                trace(CDebug, "dependants failed, skipping them")
@@ -217,7 +217,7 @@ func ifchange(tgts []string, forced, traced bool) (bool, error) {
        }
        ok := true
        for ; jobs > 0; jobs-- {
-               ok = ok && isOkRun(<-errs)
+               ok = isOkRun(<-errs) && ok
        }
        return ok, nil
 }

diff --git a/usage.go b/usage.go
index 944658b99c3933b0fc69d84f0e309b36d087f7ec..38ebb38f4e7136d0c666f4fe57400de14685e4f6 100644 (file)
--- a/usage.go
+++ b/usage.go
@@ -24,7 +24,7 @@ import (
 )
 
 const (
-       Version  = "1.11.0"
+       Version  = "1.12.0"
        Warranty = `Copyright (C) 2020-2021 Sergey Matveev
 
 This program is free software: you can redistribute it and/or modify