Proper case of variable name

[goredo.git] / run.go

diff --git a/run.go b/run.go
index bf66bc96cbd1855fbafed1420010a6a5a9ec7602..816f962e25bc23a18f369872fc8730544078dd5a 100644 (file)
--- a/run.go
+++ b/run.go
@@ -133,7 +133,7 @@ func mkdirs(pth string) error {
 }
 
 func isModified(dep *Dep, tgt *Tgt) (
-       modified bool, ourInode Inode, hshPrev Hash, err error,
+       modified bool, ourInode *Inode, hshPrev Hash, err error,
 ) {
        if dep == nil {
                return
@@ -371,7 +371,7 @@ func runScript(tgt *Tgt, errs chan error, forced, traced bool) error {
        var cmdName string
        var args []string
        if err = unix.Access(doFile.rel, unix.X_OK); err == nil {
-               cmdName = doFileT
+               cmdName = doFile.a
                args = make([]string, 0, 3)
        } else {
                cmdName = "/bin/sh"
@@ -640,7 +640,7 @@ func runScript(tgt *Tgt, errs chan error, forced, traced bool) error {
                                if StderrSilent {
                                        continue
                                }
-                               if MyPid == 0 {
+                               if MyPID == 0 {
                                        tracef(CNone, "%s", line)
                                } else {
                                        tracef(CNone, "%s %s", pid, line)
@@ -666,7 +666,7 @@ func runScript(tgt *Tgt, errs chan error, forced, traced bool) error {
 
                // Was $1 touched?
                if inode, err := inodeFromFileByPath(tgt.a); err == nil {
-                       if inodePrev == "" {
+                       if inodePrev == nil {
                                runErr.Err = Err1WasTouched
                                errs <- runErr
                                return
@@ -709,12 +709,13 @@ func runScript(tgt *Tgt, errs chan error, forced, traced bool) error {
                                err = ErrLine(err)
                                goto Finish
                        }
+                       defer fd.Close()
                        if fi, rerr := fd.Stat(); rerr == nil {
                                chmod = fi.Mode()
                        } else {
-                               err = rerr
+                               err = ErrLine(rerr)
+                               goto Finish
                        }
-                       defer fd.Close()
                } else if fiStdout.Size() > 0 {
                        fd = fdStdout
                }