Update dependencies

[goredo.git] / ood.go

diff --git a/ood.go b/ood.go
index 39c265cf787ef253bfdb6193d0bd3e9dcd094557..40e6da8b3c17f535d7f03ab4d9cbe2fa3da897ca 100644 (file)
--- a/ood.go
+++ b/ood.go
@@ -46,6 +46,8 @@ var (
        OODTgts       map[string]struct{}
        FdOODTgts     *os.File
        FdOODTgtsLock *os.File
+
+       ErrMissingTarget = errors.New("invalid format of .rec: missing Target")
 )
 
 type TgtError struct {
@@ -142,7 +144,7 @@ func isOOD(cwd, tgtOrig string, level int, seen map[string]struct{}) (bool, erro
        for _, m := range depInfo.ifchanges {
                dep := m["Target"]
                if dep == "" {
-                       return ood, TgtError{tgtOrig, errors.New("invalid format of .rec: missing Target")}
+                       return ood, TgtError{tgtOrig, ErrMissingTarget}
                }
                theirInode, err := inodeFromRec(m)
                if err != nil {
@@ -186,7 +188,7 @@ func isOOD(cwd, tgtOrig string, level int, seen map[string]struct{}) (bool, erro
                        }
                        tracef(CDebug, "ood: %s%s -> %s: same hash", indent, tgtOrig, dep)
                }
-               fd.Close() // optimization not to hold it for long
+               fd.Close()
 
                if dep == tgt {
                        tracef(CDebug, "ood: %s%s -> %s: same target", indent, tgtOrig, dep)