/*
goredo -- djb's redo implementation on pure Go
-Copyright (C) 2020-2021 Sergey Matveev <stargrave@stargrave.org>
+Copyright (C) 2020-2023 Sergey Matveev <stargrave@stargrave.org>
This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
level int,
deps map[string]map[string]struct{},
includeSrc bool,
+ seen map[string]struct{},
) []string {
cwd, tgt := cwdAndTgt(path.Join(cwd, tgtOrig))
+ tgtFull := path.Join(cwd, tgt)
+ if _, ok := seen[tgtFull]; ok {
+ return nil
+ }
depPath := path.Join(cwd, RedoDir, tgt+DepSuffix)
fdDep, err := os.Open(depPath)
if err != nil {
if err != nil {
return nil
}
+ seen[tgtFull] = struct{}{}
var alwayses []string
returnReady := false
tgtRel := cwdMustRel(cwd, tgt)
if depInfo.always {
if depInfo.build == BuildUUID {
- trace(
+ tracef(
CDebug, "ood: %s%s always, but already build",
strings.Repeat(". ", level), tgtOrig,
)
returnReady = true
} else {
- trace(CDebug, "ood: %s%s always", strings.Repeat(". ", level), tgtOrig)
+ tracef(CDebug, "ood: %s%s always", strings.Repeat(". ", level), tgtOrig)
alwayses = append(alwayses, tgtRel)
returnReady = true
}
m[tgtRel] = struct{}{}
deps[depRel] = m
}
- alwayses = append(
- alwayses,
- collectDeps(cwd, dep, level+1, deps, includeSrc)...,
- )
+ alwayses = append(alwayses,
+ collectDeps(cwd, dep, level+1, deps, includeSrc, seen)...)
}
}
return alwayses
func buildDependants(tgts []string) map[string]struct{} {
defer Jobs.Wait()
- trace(CDebug, "collecting deps")
+ tracef(CDebug, "collecting deps")
seen := map[string]struct{}{}
deps := map[string]map[string]struct{}{}
+ collectDepsSeen := make(map[string]struct{})
for _, tgtInitial := range tgts {
- for _, tgt := range collectDeps(Cwd, tgtInitial, 0, deps, false) {
+ for _, tgt := range collectDeps(Cwd, tgtInitial, 0, deps, false, collectDepsSeen) {
if tgt != tgtInitial {
seen[tgt] = struct{}{}
}
}
}
if len(seen) == 0 {
- return nil
+ return seen
}
+ collectDepsSeen = nil
levelOrig := Level
defer func() {
Level = levelOrig
}()
Level = 1
- trace(CDebug, "building %d alwayses: %v", len(seen), seen)
+ tracef(CDebug, "building %d alwayses: %v", len(seen), seen)
errs := make(chan error, len(seen))
+ ok := true
+ okChecker := make(chan struct{})
+ go func() {
+ for err := range errs {
+ ok = isOkRun(err) && ok
+ }
+ close(okChecker)
+ }()
for tgt := range seen {
- if err := runScript(tgt, errs, false); err != nil {
- trace(CErr, "always run error: %s, skipping dependants", err)
+ if err := runScript(tgt, errs, false, false); err != nil {
+ tracef(CErr, "always run error: %s, skipping dependants", err)
+ Jobs.Wait()
+ close(errs)
return nil
}
}
- ok := true
- for i := 0; i < len(seen); i++ {
- ok = ok && isOkRun(<-errs)
- }
Jobs.Wait()
close(errs)
+ <-okChecker
if !ok {
- trace(CDebug, "alwayses failed, skipping dependants")
+ tracef(CDebug, "alwayses failed, skipping dependants")
return nil
}
}
RebuildDeps:
- trace(CDebug, "checking %d dependant targets: %v", len(queueSrc), queueSrc)
- queue := []string{}
+ tracef(CDebug, "checking %d dependant targets: %v", len(queueSrc), queueSrc)
+ queue := map[string]struct{}{}
for _, tgt := range queueSrc {
for dep := range deps[tgt] {
- queue = append(queue, dep)
+ queue[dep] = struct{}{}
}
}
- trace(CDebug, "building %d dependant targets: %v", len(queue), queue)
+
+ tracef(CDebug, "building %d dependant targets: %v", len(queue), queue)
errs = make(chan error, len(queue))
+ okChecker = make(chan struct{})
jobs := 0
queueSrc = []string{}
- for _, tgt := range queue {
+ go func() {
+ for err := range errs {
+ ok = isOkRun(err) && ok
+ }
+ close(okChecker)
+ }()
+ for tgt := range queue {
ood, err := isOODWithTrace(Cwd, tgt, 0, seen)
if err != nil {
- trace(CErr, "dependant error: %s, skipping dependants", err)
+ tracef(CErr, "dependant error: %s, skipping dependants", err)
return nil
}
if !ood {
continue
}
- if err := runScript(tgt, errs, false); err != nil {
- trace(CErr, "dependant error: %s, skipping dependants", err)
+ if err := runScript(tgt, errs, false, false); err != nil {
+ tracef(CErr, "dependant error: %s, skipping dependants", err)
return nil
}
queueSrc = append(queueSrc, tgt)
seen[tgt] = struct{}{}
jobs++
}
- for i := 0; i < jobs; i++ {
- ok = ok && isOkRun(<-errs)
- }
+ Jobs.Wait()
+ close(errs)
+ <-okChecker
if !ok {
- trace(CDebug, "dependants failed, skipping them")
+ tracef(CDebug, "dependants failed, skipping them")
return nil
}
- Jobs.Wait()
- close(errs)
if jobs == 0 {
return seen
}
}
func ifchange(tgts []string, forced, traced bool) (bool, error) {
+ // only unique elements
+ m := make(map[string]struct{})
+ for _, t := range tgts {
+ m[t] = struct{}{}
+ }
+ tgts = tgts[:0]
+ for t := range m {
+ tgts = append(tgts, t)
+ }
+ m = nil
+
jsInit()
- defer jsAcquire("ifchange exiting")
- defer Jobs.Wait()
+ if !IsTopRedo {
+ defer jsAcquire("ifchange exiting")
+ }
seen := buildDependants(tgts)
+ if seen == nil {
+ Jobs.Wait()
+ return false, nil
+ }
oodTgtsClear()
- trace(CDebug, "building %d targets: %v", len(tgts), tgts)
- jobs := 0
- errs := make(chan error, len(tgts))
+ tracef(CDebug, "building %d targets: %v", len(tgts), tgts)
var ood bool
var err error
+ ok := true
+ okChecker := make(chan struct{})
+ errs := make(chan error, len(tgts))
+ go func() {
+ for err := range errs {
+ ok = isOkRun(err) && ok
+ }
+ close(okChecker)
+ }()
for _, tgt := range tgts {
if _, ok := seen[tgt]; ok {
- trace(CDebug, "%s was already build as a dependant", tgt)
+ tracef(CDebug, "%s was already build as a dependant", tgt)
continue
}
ood = true
if !forced {
ood, err = isOODWithTrace(Cwd, tgt, 0, seen)
if err != nil {
- return false, err
+ Jobs.Wait()
+ close(errs)
+ return false, ErrLine(err)
}
}
if !ood {
continue
}
if isSrc(Cwd, tgt) {
- trace(CDebug, "%s is source, not redoing", tgt)
+ tracef(CDebug, "%s is source, not redoing", tgt)
continue
}
- if err = runScript(tgt, errs, traced); err != nil {
- return false, err
+ if err = runScript(tgt, errs, forced, traced); err != nil {
+ Jobs.Wait()
+ close(errs)
+ return false, ErrLine(err)
}
- jobs++
- }
- ok := true
- for ; jobs > 0; jobs-- {
- ok = ok && isOkRun(<-errs)
}
+ Jobs.Wait()
+ close(errs)
+ <-okChecker
return ok, nil
}