]> Cypherpunks.ru repositories - gostls13.git/commitdiff
internal/zstd: use dynamic path resolution for xxhsum in FuzzXXHash
authorJes Cok <xigua67damn@gmail.com>
Wed, 8 Nov 2023 15:04:42 +0000 (15:04 +0000)
committerHeschi Kreinick <heschi@google.com>
Thu, 9 Nov 2023 17:34:06 +0000 (17:34 +0000)
Updates #64000

Change-Id: I71fb80128d7e2a1f82322cbf04f74db01dcc631b
GitHub-Last-Rev: 74135946664b1b65a0de0a9228de998429dc74f9
GitHub-Pull-Request: golang/go#64003
Reviewed-on: https://go-review.googlesource.com/c/go/+/539938
Run-TryBot: Jes Cok <xigua67damn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
src/internal/zstd/xxhash_test.go

index 032739fbc014dd9d7d0e356ff45319c5e559b755..68ca558c5fd9fe17ab7d9706b419d4bd25479f40 100644 (file)
@@ -67,10 +67,16 @@ func TestLargeXXHash(t *testing.T) {
        }
 }
 
-func FuzzXXHash(f *testing.F) {
-       if _, err := os.Stat("/usr/bin/xxhsum"); err != nil {
-               f.Skip("skipping because /usr/bin/xxhsum does not exist")
+func findXxhsum(t testing.TB) string {
+       xxhsum, err := exec.LookPath("xxhsum")
+       if err != nil {
+               t.Skip("skipping because xxhsum not found")
        }
+       return xxhsum
+}
+
+func FuzzXXHash(f *testing.F) {
+       xxhsum := findXxhsum(f)
 
        for _, test := range xxHashTests {
                f.Add([]byte(test.data))
@@ -84,7 +90,7 @@ func FuzzXXHash(f *testing.F) {
        f.Add(bigData(f))
 
        f.Fuzz(func(t *testing.T, b []byte) {
-               cmd := exec.Command("/usr/bin/xxhsum", "-H64")
+               cmd := exec.Command(xxhsum, "-H64")
                cmd.Stdin = bytes.NewReader(b)
                var hhsumHash bytes.Buffer
                cmd.Stdout = &hhsumHash