]> Cypherpunks.ru repositories - gostls13.git/commitdiff
all: disable tests that fail on Alpine
authorRuss Cox <rsc@golang.org>
Fri, 29 Jul 2022 04:32:14 +0000 (00:32 -0400)
committerRuss Cox <rsc@golang.org>
Tue, 2 Aug 2022 17:23:42 +0000 (17:23 +0000)
These changes are enough to pass all.bash using the
disabled linux-amd64-alpine builder via debugnewvm.

For #19938.
For #39857.

Change-Id: I7d160612259c77764b70d429ad94f0864689cdce
Reviewed-on: https://go-review.googlesource.com/c/go/+/419995
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
misc/cgo/test/issue1435.go
misc/cgo/test/pkg_test.go
misc/cgo/testcarchive/carchive_test.go
misc/cgo/testcshared/cshared_test.go
src/syscall/syscall_linux_test.go

index 91db155c90b9836eb38042725612b9737512c28f..3fb721ac395c2df6e2234e7b7f3d08c1e3021b31 100644 (file)
@@ -10,6 +10,7 @@ package cgotest
 import (
        "fmt"
        "os"
+       "runtime"
        "sort"
        "strings"
        "syscall"
@@ -145,6 +146,11 @@ func test1435(t *testing.T) {
        if syscall.Getuid() != 0 {
                t.Skip("skipping root only test")
        }
+       if runtime.GOOS == "linux" {
+               if _, err := os.Stat("/etc/alpine-release"); err == nil {
+                       t.Skip("skipping failing test on alpine - go.dev/issue/19938")
+               }
+       }
 
        // Launch some threads in C.
        const cts = 5
index 14013a4cd962b621f6e5a9a4cade19c0504edcb6..cbc80eee7739f431342cf8750c48caa703cea708 100644 (file)
@@ -34,6 +34,10 @@ func TestCrossPackageTests(t *testing.T) {
                case "arm64":
                        t.Skip("Can't exec cmd/go subprocess on iOS.")
                }
+       case "linux":
+               if _, err := os.Stat("/etc/alpine-release"); err == nil {
+                       t.Skip("skipping failing test on alpine - go.dev/issue/39857")
+               }
        }
 
        GOPATH, err := os.MkdirTemp("", "cgotest")
index c409c317dc7dd8ae75efcb371a885a97f26e63cf..b959bc6cfa3f66792cb61b2c98c1ea1af898903d 100644 (file)
@@ -46,6 +46,13 @@ func TestMain(m *testing.M) {
                fmt.Printf("SKIP - short mode and $GO_BUILDER_NAME not set\n")
                os.Exit(0)
        }
+       if runtime.GOOS == "linux" {
+               if _, err := os.Stat("/etc/alpine-release"); err == nil {
+                       fmt.Printf("SKIP - skipping failing test on alpine - go.dev/issue/19938\n")
+                       os.Exit(0)
+               }
+       }
+
        log.SetFlags(log.Lshortfile)
        os.Exit(testMain(m))
 }
index 7fbcff24dd7ce57df4c6d0d756321be11ef739c5..d6219dc2926d7e41aba3cc05c29ab3dc80896b17 100644 (file)
@@ -44,6 +44,12 @@ func testMain(m *testing.M) int {
                fmt.Printf("SKIP - short mode and $GO_BUILDER_NAME not set\n")
                os.Exit(0)
        }
+       if runtime.GOOS == "linux" {
+               if _, err := os.Stat("/etc/alpine-release"); err == nil {
+                       fmt.Printf("SKIP - skipping failing test on alpine - go.dev/issue/19938\n")
+                       os.Exit(0)
+               }
+       }
 
        GOOS = goEnv("GOOS")
        GOARCH = goEnv("GOARCH")
index 0444b6426625b8477c522b95854088e0f45b8606..ff128b1a19fc03bbeb668a55fed008b70f4aa5b6 100644 (file)
@@ -516,6 +516,9 @@ func TestSetuidEtc(t *testing.T) {
        if syscall.Getuid() != 0 {
                t.Skip("skipping root only test")
        }
+       if _, err := os.Stat("/etc/alpine-release"); err == nil {
+               t.Skip("skipping glibc test on alpine - go.dev/issue/19938")
+       }
        vs := []struct {
                call           string
                fn             func() error