1 // Copyright 2023 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file.
5 // This file implements a custom generator to create various go/types
6 // source files from the corresponding types2 files.
25 var filesToWrite = flag.String("write", "", `go/types files to generate, or "all" for all files`)
28 srcDir = "/src/cmd/compile/internal/types2/"
29 dstDir = "/src/go/types/"
32 // TestGenerate verifies that generated files in go/types match their types2
33 // counterpart. If -write is set, this test actually writes the expected
34 // content to go/types; otherwise, it just compares with the existing content.
35 func TestGenerate(t *testing.T) {
36 // If filesToWrite is set, write the generated content to disk.
37 // In the special case of "all", write all files in filemap.
38 write := *filesToWrite != ""
39 var files []string // files to process
40 if *filesToWrite != "" && *filesToWrite != "all" {
41 files = strings.Split(*filesToWrite, ",")
43 for file := range filemap {
44 files = append(files, file)
48 for _, filename := range files {
49 generate(t, filename, write)
53 func generate(t *testing.T, filename string, write bool) {
55 srcFilename := filepath.FromSlash(runtime.GOROOT() + srcDir + filename)
56 file, err := parser.ParseFile(fset, srcFilename, nil, parser.ParseComments)
62 file.Name.Name = strings.ReplaceAll(file.Name.Name, "types2", "types")
64 // rewrite AST as needed
65 if action := filemap[filename]; action != nil {
71 buf.WriteString("// Code generated by \"go test -run=Generate -write=all\"; DO NOT EDIT.\n\n")
72 if err := format.Node(&buf, fset, file); err != nil {
75 generatedContent := buf.Bytes()
77 dstFilename := filepath.FromSlash(runtime.GOROOT() + dstDir + filename)
78 onDiskContent, err := os.ReadFile(dstFilename)
80 t.Fatalf("reading %q: %v", filename, err)
83 if d := diff.Diff(filename+" (on disk)", onDiskContent, filename+" (generated)", generatedContent); d != nil {
85 t.Logf("applying change:\n%s", d)
86 if err := os.WriteFile(dstFilename, generatedContent, 0o644); err != nil {
87 t.Fatalf("writing %q: %v", filename, err)
90 t.Errorf("generated file content does not match:\n%s", string(d))
95 type action func(in *ast.File)
97 var filemap = map[string]action{
102 "const.go": func(f *ast.File) { fixTokenPos(f) },
104 "context_test.go": nil,
105 "gccgosizes.go": nil,
106 "gcsizes.go": func(f *ast.File) { renameIdent(f, "IsSyncAtomicAlign64", "_IsSyncAtomicAlign64") },
107 "hilbert_test.go": func(f *ast.File) { renameImportPath(f, `"cmd/compile/internal/types2"`, `"go/types"`) },
108 "infer.go": func(f *ast.File) {
112 // "initorder.go": fixErrErrorfCall, // disabled for now due to unresolved error_ use implications for gopls
113 "instantiate.go": func(f *ast.File) { fixTokenPos(f); fixCheckErrorfCall(f) },
114 "instantiate_test.go": func(f *ast.File) { renameImportPath(f, `"cmd/compile/internal/types2"`, `"go/types"`) },
115 "lookup.go": func(f *ast.File) { fixTokenPos(f) },
118 "named.go": func(f *ast.File) { fixTokenPos(f); fixTraceSel(f) },
119 "object.go": func(f *ast.File) { fixTokenPos(f); renameIdent(f, "NewTypeNameLazy", "_NewTypeNameLazy") },
120 "object_test.go": func(f *ast.File) { renameImportPath(f, `"cmd/compile/internal/types2"`, `"go/types"`) },
124 "predicates.go": nil,
125 "scope.go": func(f *ast.File) {
127 renameIdent(f, "Squash", "squash")
128 renameIdent(f, "InsertLazy", "_InsertLazy")
131 "sizes.go": func(f *ast.File) { renameIdent(f, "IsSyncAtomicAlign64", "_IsSyncAtomicAlign64") },
133 "subst.go": func(f *ast.File) { fixTokenPos(f); fixTraceSel(f) },
135 "termlist_test.go": nil,
139 "typeterm_test.go": nil,
142 "unify.go": fixSprintf,
143 "universe.go": fixGlobalTypVarDecl,
144 "util_test.go": fixTokenPos,
148 // TODO(gri) We should be able to make these rewriters more configurable/composable.
149 // For now this is a good starting point.
151 // renameIdent renames an identifier.
152 // Note: This doesn't change the use of the identifier in comments.
153 func renameIdent(f *ast.File, from, to string) {
154 ast.Inspect(f, func(n ast.Node) bool {
155 switch n := n.(type) {
166 // renameImportPath renames an import path.
167 func renameImportPath(f *ast.File, from, to string) {
168 ast.Inspect(f, func(n ast.Node) bool {
169 switch n := n.(type) {
170 case *ast.ImportSpec:
171 if n.Path.Kind == token.STRING && n.Path.Value == from {
180 // fixTokenPos changes imports of "cmd/compile/internal/syntax" to "go/token",
181 // uses of syntax.Pos to token.Pos, and calls to x.IsKnown() to x.IsValid().
182 func fixTokenPos(f *ast.File) {
183 ast.Inspect(f, func(n ast.Node) bool {
184 switch n := n.(type) {
185 case *ast.ImportSpec:
186 // rewrite import path "cmd/compile/internal/syntax" to "go/token"
187 if n.Path.Kind == token.STRING && n.Path.Value == `"cmd/compile/internal/syntax"` {
188 n.Path.Value = `"go/token"`
191 case *ast.SelectorExpr:
192 // rewrite syntax.Pos to token.Pos
193 if x, _ := n.X.(*ast.Ident); x != nil && x.Name == "syntax" && n.Sel.Name == "Pos" {
198 // rewrite x.IsKnown() to x.IsValid()
199 if fun, _ := n.Fun.(*ast.SelectorExpr); fun != nil && fun.Sel.Name == "IsKnown" && len(n.Args) == 0 {
200 fun.Sel.Name = "IsValid"
208 // fixInferSig updates the Checker.infer signature to use a positioner instead of a token.Position
209 // as first argument, renames the argument from "pos" to "posn", and updates a few internal uses of
210 // "pos" to "posn" and "posn.Pos()" respectively.
211 func fixInferSig(f *ast.File) {
212 ast.Inspect(f, func(n ast.Node) bool {
213 switch n := n.(type) {
215 if n.Name.Name == "infer" {
216 // rewrite (pos token.Pos, ...) to (posn positioner, ...)
217 par := n.Type.Params.List[0]
218 if len(par.Names) == 1 && par.Names[0].Name == "pos" {
219 par.Names[0] = newIdent(par.Names[0].Pos(), "posn")
220 par.Type = newIdent(par.Type.Pos(), "positioner")
225 if selx, _ := n.Fun.(*ast.SelectorExpr); selx != nil {
226 switch selx.Sel.Name {
227 case "renameTParams":
228 // rewrite check.renameTParams(pos, ... ) to check.renameTParams(posn.Pos(), ... )
229 if ident, _ := n.Args[0].(*ast.Ident); ident != nil && ident.Name == "pos" {
230 pos := n.Args[0].Pos()
231 fun := &ast.SelectorExpr{X: newIdent(pos, "posn"), Sel: newIdent(pos, "Pos")}
232 arg := &ast.CallExpr{Fun: fun, Lparen: pos, Args: nil, Ellipsis: token.NoPos, Rparen: pos}
237 // rewrite check.errorf(pos, ...) to check.errorf(posn, ...)
238 if ident, _ := n.Args[0].(*ast.Ident); ident != nil && ident.Name == "pos" {
239 pos := n.Args[0].Pos()
240 arg := newIdent(pos, "posn")
245 // rewrite check.allowVersion(..., pos, ...) to check.allowVersion(..., posn, ...)
246 if ident, _ := n.Args[1].(*ast.Ident); ident != nil && ident.Name == "pos" {
247 pos := n.Args[1].Pos()
248 arg := newIdent(pos, "posn")
259 // fixErrErrorfCall updates calls of the form err.errorf(obj, ...) to err.errorf(obj.Pos(), ...).
260 func fixErrErrorfCall(f *ast.File) {
261 ast.Inspect(f, func(n ast.Node) bool {
262 switch n := n.(type) {
264 if selx, _ := n.Fun.(*ast.SelectorExpr); selx != nil {
265 if ident, _ := selx.X.(*ast.Ident); ident != nil && ident.Name == "err" {
266 switch selx.Sel.Name {
268 // rewrite err.errorf(obj, ... ) to err.errorf(obj.Pos(), ... )
269 if ident, _ := n.Args[0].(*ast.Ident); ident != nil && ident.Name == "obj" {
270 pos := n.Args[0].Pos()
271 fun := &ast.SelectorExpr{X: ident, Sel: newIdent(pos, "Pos")}
272 arg := &ast.CallExpr{Fun: fun, Lparen: pos, Args: nil, Ellipsis: token.NoPos, Rparen: pos}
284 // fixCheckErrorfCall updates calls of the form check.errorf(pos, ...) to check.errorf(atPos(pos), ...).
285 func fixCheckErrorfCall(f *ast.File) {
286 ast.Inspect(f, func(n ast.Node) bool {
287 switch n := n.(type) {
289 if selx, _ := n.Fun.(*ast.SelectorExpr); selx != nil {
290 if ident, _ := selx.X.(*ast.Ident); ident != nil && ident.Name == "check" {
291 switch selx.Sel.Name {
293 // rewrite check.errorf(pos, ... ) to check.errorf(atPos(pos), ... )
294 if ident, _ := n.Args[0].(*ast.Ident); ident != nil && ident.Name == "pos" {
295 pos := n.Args[0].Pos()
296 fun := newIdent(pos, "atPos")
297 arg := &ast.CallExpr{Fun: fun, Lparen: pos, Args: []ast.Expr{ident}, Ellipsis: token.NoPos, Rparen: pos}
309 // fixTraceSel renames uses of x.Trace to x.trace, where x for any x with a Trace field.
310 func fixTraceSel(f *ast.File) {
311 ast.Inspect(f, func(n ast.Node) bool {
312 switch n := n.(type) {
313 case *ast.SelectorExpr:
314 // rewrite x.Trace to x._Trace (for Config.Trace)
315 if n.Sel.Name == "Trace" {
316 n.Sel.Name = "_Trace"
324 // fixGlobalTypVarDecl changes the global Typ variable from an array to a slice
325 // (in types2 we use an array for efficiency, in go/types it's a slice and we
326 // cannot change that).
327 func fixGlobalTypVarDecl(f *ast.File) {
328 ast.Inspect(f, func(n ast.Node) bool {
329 switch n := n.(type) {
331 // rewrite type Typ = [...]Type{...} to type Typ = []Type{...}
332 if len(n.Names) == 1 && n.Names[0].Name == "Typ" && len(n.Values) == 1 {
333 n.Values[0].(*ast.CompositeLit).Type.(*ast.ArrayType).Len = nil
341 // fixSprintf adds an extra nil argument for the *token.FileSet parameter in sprintf calls.
342 func fixSprintf(f *ast.File) {
343 ast.Inspect(f, func(n ast.Node) bool {
344 switch n := n.(type) {
346 if fun, _ := n.Fun.(*ast.Ident); fun != nil && fun.Name == "sprintf" && len(n.Args) >= 4 /* ... args */ {
347 n.Args = insert(n.Args, 1, newIdent(n.Args[1].Pos(), "nil"))
355 // newIdent returns a new identifier with the given position and name.
356 func newIdent(pos token.Pos, name string) *ast.Ident {
357 id := ast.NewIdent(name)
362 // insert inserts x at list[at] and moves the remaining elements up.
363 func insert(list []ast.Expr, at int, x ast.Expr) []ast.Expr {
364 list = append(list, nil)
365 copy(list[at+1:], list[at:])