1 // Copyright 2011 The Go Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style
3 // license that can be found in the LICENSE file.
5 // This file implements a typechecker test harness. The packages specified
6 // in tests are typechecked. Error messages reported by the typechecker are
7 // compared against the errors expected in the test files.
9 // Expected errors are indicated in the test files by putting comments
10 // of the form /* ERROR pattern */ or /* ERRORx pattern */ (or a similar
11 // //-style line comment) immediately following the tokens where errors
12 // are reported. There must be exactly one blank before and after the
13 // ERROR/ERRORx indicator, and the pattern must be a properly quoted Go
16 // The harness will verify that each ERROR pattern is a substring of the
17 // error reported at that source position, and that each ERRORx pattern
18 // is a regular expression matching the respective error.
19 // Consecutive comments may be used to indicate multiple errors reported
20 // at the same position.
22 // For instance, the following test source indicates that an "undeclared"
23 // error should be reported for the undeclared variable x:
27 // _ = x /* ERROR "undeclared" */ + 1
43 "internal/types/errors"
57 haltOnError = flag.Bool("halt", false, "halt on error")
58 verifyErrors = flag.Bool("verify", false, "verify errors (rather than list them) in TestManual")
61 var fset = token.NewFileSet()
63 func parseFiles(t *testing.T, filenames []string, srcs [][]byte, mode parser.Mode) ([]*ast.File, []error) {
66 for i, filename := range filenames {
67 file, err := parser.ParseFile(fset, filename, srcs[i], mode)
69 t.Fatalf("%s: %s", filename, err)
71 files = append(files, file)
73 if list, _ := err.(scanner.ErrorList); len(list) > 0 {
74 for _, err := range list {
75 errlist = append(errlist, err)
78 errlist = append(errlist, err)
85 func unpackError(fset *token.FileSet, err error) (token.Position, string) {
86 switch err := err.(type) {
88 return err.Pos, err.Msg
90 return fset.Position(err.Pos), err.Msg
95 // absDiff returns the absolute difference between x and y.
96 func absDiff(x, y int) int {
103 // parseFlags parses flags from the first line of the given source if the line
104 // starts with "//" (line comment) followed by "-" (possibly with spaces
105 // between). Otherwise the line is ignored.
106 func parseFlags(src []byte, flags *flag.FlagSet) error {
107 // we must have a line comment that starts with a "-"
109 if !bytes.HasPrefix(src, []byte(prefix)) {
110 return nil // first line is not a line comment
112 src = src[len(prefix):]
113 if i := bytes.Index(src, []byte("-")); i < 0 || len(bytes.TrimSpace(src[:i])) != 0 {
114 return nil // comment doesn't start with a "-"
116 end := bytes.Index(src, []byte("\n"))
118 if end < 0 || end > maxLen {
119 return fmt.Errorf("flags comment line too long")
122 return flags.Parse(strings.Fields(string(src[:end])))
125 // testFiles type-checks the package consisting of the given files, and
126 // compares the resulting errors with the ERROR annotations in the source.
128 // The srcs slice contains the file content for the files named in the
129 // filenames slice. The manual parameter specifies whether this is a 'manual'
132 // If provided, opts may be used to mutate the Config before type-checking.
133 func testFiles(t *testing.T, filenames []string, srcs [][]byte, manual bool, opts ...func(*Config)) {
134 if len(filenames) == 0 {
135 t.Fatal("no source files")
139 var goexperiment string
140 flags := flag.NewFlagSet("", flag.PanicOnError)
141 flags.StringVar(&conf.GoVersion, "lang", "", "")
142 flags.StringVar(&goexperiment, "goexperiment", "", "")
143 flags.BoolVar(&conf.FakeImportC, "fakeImportC", false, "")
144 if err := parseFlags(srcs[0], flags); err != nil {
147 exp, err := buildcfg.ParseGOEXPERIMENT(runtime.GOOS, runtime.GOARCH, goexperiment)
151 old := buildcfg.Experiment
153 buildcfg.Experiment = old
155 buildcfg.Experiment = *exp
157 files, errlist := parseFiles(t, filenames, srcs, parser.AllErrors)
159 pkgName := "<no package>"
161 pkgName = files[0].Name.Name
164 listErrors := manual && !*verifyErrors
165 if listErrors && len(errlist) > 0 {
166 t.Errorf("--- %s:", pkgName)
167 for _, err := range errlist {
172 // typecheck and collect typechecker errors
173 *boolFieldAddr(&conf, "_Trace") = manual && testing.Verbose()
174 conf.Importer = importer.Default()
175 conf.Error = func(err error) {
183 // Ignore secondary error messages starting with "\t";
184 // they are clarifying messages for a primary error.
185 if !strings.Contains(err.Error(), ": \t") {
186 errlist = append(errlist, err)
190 for _, opt := range opts {
194 // Provide Config.Info with all maps so that info recording is tested.
196 Types: make(map[ast.Expr]TypeAndValue),
197 Instances: make(map[*ast.Ident]Instance),
198 Defs: make(map[*ast.Ident]Object),
199 Uses: make(map[*ast.Ident]Object),
200 Implicits: make(map[ast.Node]Object),
201 Selections: make(map[*ast.SelectorExpr]*Selection),
202 Scopes: make(map[ast.Node]*Scope),
204 conf.Check(pkgName, fset, files, &info)
210 // collect expected errors
211 errmap := make(map[string]map[int][]comment)
212 for i, filename := range filenames {
213 if m := commentMap(srcs[i], regexp.MustCompile("^ ERRORx? ")); len(m) > 0 {
218 // match against found errors
219 var indices []int // list indices of matching errors, reused for each error
220 for _, err := range errlist {
221 gotPos, gotMsg := unpackError(fset, err)
223 // find list of errors for the respective error line
224 filename := gotPos.Filename
225 filemap := errmap[filename]
227 var errList []comment
229 errList = filemap[line]
232 // At least one of the errors in errList should match the current error.
233 indices = indices[:0]
234 for i, want := range errList {
235 pattern, substr := strings.CutPrefix(want.text, " ERROR ")
238 pattern, found = strings.CutPrefix(want.text, " ERRORx ")
243 pattern, err := strconv.Unquote(strings.TrimSpace(pattern))
245 t.Errorf("%s:%d:%d: %v", filename, line, want.col, err)
249 if !strings.Contains(gotMsg, pattern) {
253 rx, err := regexp.Compile(pattern)
255 t.Errorf("%s:%d:%d: %v", filename, line, want.col, err)
258 if !rx.MatchString(gotMsg) {
262 indices = append(indices, i)
264 if len(indices) == 0 {
265 t.Errorf("%s: no error expected: %q", gotPos, gotMsg)
270 // If there are multiple matching errors, select the one with the closest column position.
271 index := -1 // index of matching error
273 for _, i := range indices {
274 if d := absDiff(gotPos.Column, errList[i].col); index < 0 || d < delta {
279 // The closest column position must be within expected colDelta.
280 const colDelta = 0 // go/types errors are positioned correctly
281 if delta > colDelta {
282 t.Errorf("%s: got col = %d; want %d", gotPos, gotPos.Column, errList[index].col)
285 // eliminate from errList
286 if n := len(errList) - 1; n > 0 {
287 // not the last entry - slide entries down (don't reorder)
288 copy(errList[index:], errList[index+1:])
289 filemap[line] = errList[:n]
291 // last entry - remove errList from filemap
292 delete(filemap, line)
295 // if filemap is empty, eliminate from errmap
296 if len(filemap) == 0 {
297 delete(errmap, filename)
301 // there should be no expected errors left
303 t.Errorf("--- %s: unreported errors:", pkgName)
304 for filename, filemap := range errmap {
305 for line, errList := range filemap {
306 for _, err := range errList {
307 t.Errorf("%s:%d:%d: %s", filename, line, err.col, err.text)
314 func readCode(err Error) errors.Code {
315 v := reflect.ValueOf(err)
316 return errors.Code(v.FieldByName("go116code").Int())
319 // boolFieldAddr(conf, name) returns the address of the boolean field conf.<name>.
320 // For accessing unexported fields.
321 func boolFieldAddr(conf *Config, name string) *bool {
322 v := reflect.Indirect(reflect.ValueOf(conf))
323 return (*bool)(v.FieldByName(name).Addr().UnsafePointer())
326 // stringFieldAddr(conf, name) returns the address of the string field conf.<name>.
327 // For accessing unexported fields.
328 func stringFieldAddr(conf *Config, name string) *string {
329 v := reflect.Indirect(reflect.ValueOf(conf))
330 return (*string)(v.FieldByName(name).Addr().UnsafePointer())
333 // TestManual is for manual testing of a package - either provided
334 // as a list of filenames belonging to the package, or a directory
335 // name containing the package files - after the test arguments
336 // (and a separating "--"). For instance, to test the package made
337 // of the files foo.go and bar.go, use:
339 // go test -run Manual -- foo.go bar.go
341 // If no source arguments are provided, the file testdata/manual.go
343 // Provide the -verify flag to verify errors against ERROR comments
344 // in the input files rather than having a list of errors reported.
345 // The accepted Go language version can be controlled with the -lang
347 func TestManual(t *testing.T) {
348 testenv.MustHaveGoBuild(t)
350 filenames := flag.Args()
351 if len(filenames) == 0 {
352 filenames = []string{filepath.FromSlash("testdata/manual.go")}
355 info, err := os.Stat(filenames[0])
357 t.Fatalf("TestManual: %v", err)
360 DefPredeclaredTestFuncs()
362 if len(filenames) > 1 {
363 t.Fatal("TestManual: must have only one directory argument")
365 testDir(t, filenames[0], true)
367 testPkg(t, filenames, true)
371 func TestLongConstants(t *testing.T) {
372 format := `package longconst; const _ = %s /* ERROR "constant overflow" */; const _ = %s // ERROR "excessively long constant"`
373 src := fmt.Sprintf(format, strings.Repeat("1", 9999), strings.Repeat("1", 10001))
374 testFiles(t, []string{"longconst.go"}, [][]byte{[]byte(src)}, false)
377 func withSizes(sizes Sizes) func(*Config) {
378 return func(cfg *Config) {
383 // TestIndexRepresentability tests that constant index operands must
384 // be representable as int even if they already have a type that can
385 // represent larger values.
386 func TestIndexRepresentability(t *testing.T) {
387 const src = `package index; var s []byte; var _ = s[int64 /* ERRORx "int64\\(1\\) << 40 \\(.*\\) overflows int" */ (1) << 40]`
388 testFiles(t, []string{"index.go"}, [][]byte{[]byte(src)}, false, withSizes(&StdSizes{4, 4}))
391 func TestIssue47243_TypedRHS(t *testing.T) {
392 // The RHS of the shift expression below overflows uint on 32bit platforms,
393 // but this is OK as it is explicitly typed.
394 const src = `package issue47243; var a uint64; var _ = a << uint64(4294967296)` // uint64(1<<32)
395 testFiles(t, []string{"p.go"}, [][]byte{[]byte(src)}, false, withSizes(&StdSizes{4, 4}))
398 func TestCheck(t *testing.T) {
399 old := buildcfg.Experiment.RangeFunc
401 buildcfg.Experiment.RangeFunc = old
403 buildcfg.Experiment.RangeFunc = true
405 DefPredeclaredTestFuncs()
406 testDirFiles(t, "../../internal/types/testdata/check", false)
408 func TestSpec(t *testing.T) { testDirFiles(t, "../../internal/types/testdata/spec", false) }
409 func TestExamples(t *testing.T) { testDirFiles(t, "../../internal/types/testdata/examples", false) }
410 func TestFixedbugs(t *testing.T) { testDirFiles(t, "../../internal/types/testdata/fixedbugs", false) }
411 func TestLocal(t *testing.T) { testDirFiles(t, "testdata/local", false) }
413 func testDirFiles(t *testing.T, dir string, manual bool) {
414 testenv.MustHaveGoBuild(t)
415 dir = filepath.FromSlash(dir)
417 fis, err := os.ReadDir(dir)
423 for _, fi := range fis {
424 path := filepath.Join(dir, fi.Name())
426 // If fi is a directory, its files make up a single package.
428 testDir(t, path, manual)
430 t.Run(filepath.Base(path), func(t *testing.T) {
431 testPkg(t, []string{path}, manual)
437 func testDir(t *testing.T, dir string, manual bool) {
438 testenv.MustHaveGoBuild(t)
440 fis, err := os.ReadDir(dir)
446 var filenames []string
447 for _, fi := range fis {
448 filenames = append(filenames, filepath.Join(dir, fi.Name()))
451 t.Run(filepath.Base(dir), func(t *testing.T) {
452 testPkg(t, filenames, manual)
456 func testPkg(t *testing.T, filenames []string, manual bool) {
457 srcs := make([][]byte, len(filenames))
458 for i, filename := range filenames {
459 src, err := os.ReadFile(filename)
461 t.Fatalf("could not read %s: %v", filename, err)
465 testFiles(t, filenames, srcs, manual)