]> Cypherpunks.ru repositories - gocheese.git/blobdiff - gocheese.go
Check for 404 error of .asc downloads
[gocheese.git] / gocheese.go
index b27df8c02f80cba03bb636a2a76f6865815be25c..5ecd959bc61e6f1a5881f8dc0d6b8c6b97b43de6 100644 (file)
@@ -1,6 +1,7 @@
 /*
 GoCheese -- Python private package repository and caching proxy
 Copyright (C) 2019 Sergey Matveev <stargrave@stargrave.org>
+              2019 Elena Balakhonova <balakhonova_e@riseup.net>
 
 This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
@@ -20,6 +21,7 @@ package main
 
 import (
        "bytes"
+       "context"
        "crypto/sha256"
        "encoding/hex"
        "flag"
@@ -27,22 +29,36 @@ import (
        "io"
        "io/ioutil"
        "log"
+       "net"
        "net/http"
        "net/url"
        "os"
+       "os/signal"
        "path/filepath"
        "regexp"
        "runtime"
        "strings"
+       "syscall"
+       "time"
+
+       "golang.org/x/net/netutil"
 )
 
 const (
-       HTMLBegin    = "<!DOCTYPE html><html><head><title>Links for %s</title></head><body><h1>Links for %s</h1>\n"
-       HTMLEnd      = "</body></html>"
-       HTMLElement  = "<a href='%s'>%s</a><br/>\n"
+       HTMLBegin = `<!DOCTYPE html>
+<html>
+  <head>
+    <title>Links for %s</title>
+  </head>
+  <body>
+`
+       HTMLEnd      = "  </body>\n</html>\n"
+       HTMLElement  = "    <a href=\"%s\"%s>%s</a><br/>\n"
        SHA256Prefix = "sha256="
        SHA256Ext    = ".sha256"
        InternalFlag = ".internal"
+       GPGSigExt    = ".asc"
+       GPGSigAttr   = " data-gpg-sig=true"
 
        Warranty = `This program is free software: you can redistribute it and/or modify
 it under the terms of the GNU General Public License as published by
@@ -58,26 +74,33 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.`
 )
 
 var (
+       pkgPyPI        = regexp.MustCompile(`^.*<a href="([^"]+)"[^>]*>(.+)</a><br/>.*$`)
+       Version string = "UNKNOWN"
+
        root             = flag.String("root", "./packages", "Path to packages directory")
        bind             = flag.String("bind", "[::]:8080", "Address to bind to")
+       tlsCert          = flag.String("tls-cert", "", "Path to TLS X.509 certificate")
+       tlsKey           = flag.String("tls-key", "", "Path to TLS X.509 private key")
        norefreshURLPath = flag.String("norefresh", "/norefresh/", "Non-refreshing URL path")
        refreshURLPath   = flag.String("refresh", "/simple/", "Auto-refreshing URL path")
+       gpgUpdateURLPath = flag.String("gpgupdate", "/gpgupdate/", "GPG forceful refreshing URL path")
        pypiURL          = flag.String("pypi", "https://pypi.org/simple/", "Upstream PyPI URL")
-       passwdPath       = flag.String("passwd", "passwd", "Path to file with login:password lines")
+       passwdPath       = flag.String("passwd", "passwd", "Path to file with authenticators")
+       passwdCheck      = flag.Bool("passwd-check", false, "Test the -passwd file for syntax errors and exit")
        fsck             = flag.Bool("fsck", false, "Check integrity of all packages")
+       maxClients       = flag.Int("maxclients", 128, "Maximal amount of simultaneous clients")
        version          = flag.Bool("version", false, "Print version information")
        warranty         = flag.Bool("warranty", false, "Print warranty information")
 
-       pkgPyPI        = regexp.MustCompile(`^.*<a href="([^"]+)"[^>]*>(.+)</a><br/>.*$`)
-       Version string = "UNKNOWN"
+       killed bool
 
-       passwords map[string]string = make(map[string]string)
+       normalizationRe *regexp.Regexp = regexp.MustCompilePOSIX("[-_.]+")
 )
 
 func mkdirForPkg(w http.ResponseWriter, r *http.Request, dir string) bool {
        path := filepath.Join(*root, dir)
        if _, err := os.Stat(path); os.IsNotExist(err) {
-               if err = os.Mkdir(path, 0700); err != nil {
+               if err = os.Mkdir(path, os.FileMode(0777)); err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return false
                }
@@ -86,19 +109,23 @@ func mkdirForPkg(w http.ResponseWriter, r *http.Request, dir string) bool {
        return true
 }
 
-func refreshDir(w http.ResponseWriter, r *http.Request, dir, filenameGet string) bool {
+func refreshDir(
+       w http.ResponseWriter,
+       r *http.Request,
+       dir,
+       filenameGet string,
+       gpgUpdate bool,
+) bool {
        if _, err := os.Stat(filepath.Join(*root, dir, InternalFlag)); err == nil {
-               log.Println(r.RemoteAddr, "pypi refresh skip, internal package", dir)
                return true
        }
-       log.Println(r.RemoteAddr, "pypi refresh", dir)
        resp, err := http.Get(*pypiURL + dir + "/")
        if err != nil {
                http.Error(w, err.Error(), http.StatusBadGateway)
                return false
        }
-       defer resp.Body.Close()
        body, err := ioutil.ReadAll(resp.Body)
+       resp.Body.Close()
        if err != nil {
                http.Error(w, err.Error(), http.StatusBadGateway)
                return false
@@ -106,6 +133,7 @@ func refreshDir(w http.ResponseWriter, r *http.Request, dir, filenameGet string)
        if !mkdirForPkg(w, r, dir) {
                return false
        }
+       dirPath := filepath.Join(*root, dir)
        var submatches []string
        var uri string
        var filename string
@@ -128,17 +156,23 @@ func refreshDir(w http.ResponseWriter, r *http.Request, dir, filenameGet string)
                        http.Error(w, err.Error(), http.StatusBadGateway)
                        return false
                }
+               pkgURL.Fragment = ""
+               path = filepath.Join(dirPath, filename)
                if filename == filenameGet {
+                       if killed {
+                               // Skip heavy remote call, when shutting down
+                               http.Error(w, "shutting down", http.StatusInternalServerError)
+                               return false
+                       }
                        log.Println(r.RemoteAddr, "pypi download", filename)
-                       path = filepath.Join(*root, dir, filename)
-                       resp, err = http.Get(uri)
+                       resp, err = http.Get(pkgURL.String())
                        if err != nil {
                                http.Error(w, err.Error(), http.StatusBadGateway)
                                return false
                        }
                        defer resp.Body.Close()
                        hasher := sha256.New()
-                       dst, err := ioutil.TempFile(filepath.Join(*root, dir), "")
+                       dst, err := TempFile(dirPath)
                        if err != nil {
                                http.Error(w, err.Error(), http.StatusInternalServerError)
                                return false
@@ -168,19 +202,46 @@ func refreshDir(w http.ResponseWriter, r *http.Request, dir, filenameGet string)
                                http.Error(w, err.Error(), http.StatusInternalServerError)
                                return false
                        }
+                       if err = DirSync(dirPath); err != nil {
+                               http.Error(w, err.Error(), http.StatusInternalServerError)
+                               return false
+                       }
                }
-               path = filepath.Join(*root, dir, filename+SHA256Ext)
-               _, err = os.Stat(path)
-               if err == nil {
-                       continue
-               } else {
-                       if !os.IsNotExist(err) {
+               if filename == filenameGet || gpgUpdate {
+                       if _, err = os.Stat(path); err != nil {
+                               goto GPGSigSkip
+                       }
+                       resp, err := http.Get(pkgURL.String() + GPGSigExt)
+                       if err != nil {
+                               goto GPGSigSkip
+                       }
+                       if resp.StatusCode != http.StatusOK {
+                               resp.Body.Close()
+                               goto GPGSigSkip
+                       }
+                       sig, err := ioutil.ReadAll(resp.Body)
+                       resp.Body.Close()
+                       if err != nil {
+                               goto GPGSigSkip
+                       }
+                       if err = WriteFileSync(dirPath, path+GPGSigExt, sig); err != nil {
                                http.Error(w, err.Error(), http.StatusInternalServerError)
                                return false
                        }
+                       log.Println(r.RemoteAddr, "pypi downloaded signature", filename)
+               }
+       GPGSigSkip:
+               path = path + SHA256Ext
+               _, err = os.Stat(path)
+               if err == nil {
+                       continue
+               }
+               if !os.IsNotExist(err) {
+                       http.Error(w, err.Error(), http.StatusInternalServerError)
+                       return false
                }
                log.Println(r.RemoteAddr, "pypi touch", filename)
-               if err = ioutil.WriteFile(path, digest, os.FileMode(0600)); err != nil {
+               if err = WriteFileSync(dirPath, path, digest); err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return false
                }
@@ -189,33 +250,39 @@ func refreshDir(w http.ResponseWriter, r *http.Request, dir, filenameGet string)
 }
 
 func listRoot(w http.ResponseWriter, r *http.Request) {
-       log.Println(r.RemoteAddr, "root")
        files, err := ioutil.ReadDir(*root)
        if err != nil {
                http.Error(w, err.Error(), http.StatusInternalServerError)
                return
        }
-       w.Write([]byte(fmt.Sprintf(HTMLBegin, "root", "root")))
+       var result bytes.Buffer
+       result.WriteString(fmt.Sprintf(HTMLBegin, "root"))
        for _, file := range files {
                if file.Mode().IsDir() {
-                       w.Write([]byte(fmt.Sprintf(
+                       result.WriteString(fmt.Sprintf(
                                HTMLElement,
                                *refreshURLPath+file.Name()+"/",
                                file.Name(),
-                       )))
+                       ))
                }
        }
-       w.Write([]byte(HTMLEnd))
+       result.WriteString(HTMLEnd)
+       w.Write(result.Bytes())
 }
 
-func listDir(w http.ResponseWriter, r *http.Request, dir string, autorefresh bool) {
-       log.Println(r.RemoteAddr, "dir", dir)
+func listDir(
+       w http.ResponseWriter,
+       r *http.Request,
+       dir string,
+       autorefresh,
+       gpgUpdate bool,
+) {
        dirPath := filepath.Join(*root, dir)
        if autorefresh {
-               if !refreshDir(w, r, dir, "") {
+               if !refreshDir(w, r, dir, "", gpgUpdate) {
                        return
                }
-       } else if _, err := os.Stat(dirPath); os.IsNotExist(err) && !refreshDir(w, r, dir, "") {
+       } else if _, err := os.Stat(dirPath); os.IsNotExist(err) && !refreshDir(w, r, dir, "", false) {
                return
        }
        files, err := ioutil.ReadDir(dirPath)
@@ -223,36 +290,50 @@ func listDir(w http.ResponseWriter, r *http.Request, dir string, autorefresh boo
                http.Error(w, err.Error(), http.StatusInternalServerError)
                return
        }
-       w.Write([]byte(fmt.Sprintf(HTMLBegin, dir, dir)))
+       var result bytes.Buffer
+       result.WriteString(fmt.Sprintf(HTMLBegin, dir))
        var data []byte
+       var gpgSigAttr string
        var filenameClean string
        for _, file := range files {
                if !strings.HasSuffix(file.Name(), SHA256Ext) {
                        continue
                }
+               if killed {
+                       // Skip expensive I/O when shutting down
+                       http.Error(w, "shutting down", http.StatusInternalServerError)
+                       return
+               }
                data, err = ioutil.ReadFile(filepath.Join(dirPath, file.Name()))
                if err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return
                }
                filenameClean = strings.TrimSuffix(file.Name(), SHA256Ext)
-               w.Write([]byte(fmt.Sprintf(
+               if _, err = os.Stat(filepath.Join(dirPath, filenameClean+GPGSigExt)); os.IsNotExist(err) {
+                       gpgSigAttr = ""
+               } else {
+                       gpgSigAttr = GPGSigAttr
+               }
+               result.WriteString(fmt.Sprintf(
                        HTMLElement,
                        strings.Join([]string{
                                *refreshURLPath, dir, "/",
-                               filenameClean, "#", SHA256Prefix, string(data),
+                               filenameClean, "#", SHA256Prefix, hex.EncodeToString(data),
                        }, ""),
+                       gpgSigAttr,
                        filenameClean,
-               )))
+               ))
        }
-       w.Write([]byte(HTMLEnd))
+       result.WriteString(HTMLEnd)
+       w.Write(result.Bytes())
 }
 
 func servePkg(w http.ResponseWriter, r *http.Request, dir, filename string) {
-       log.Println(r.RemoteAddr, "pkg", filename)
+       log.Println(r.RemoteAddr, "get", filename)
        path := filepath.Join(*root, dir, filename)
        if _, err := os.Stat(path); os.IsNotExist(err) {
-               if !refreshDir(w, r, dir, filename) {
+               if !refreshDir(w, r, dir, filename, false) {
                        return
                }
        }
@@ -260,47 +341,70 @@ func servePkg(w http.ResponseWriter, r *http.Request, dir, filename string) {
 }
 
 func serveUpload(w http.ResponseWriter, r *http.Request) {
+       // Authentication
        username, password, ok := r.BasicAuth()
-       if !ok || passwords[username] != password {
+       if !ok {
                log.Println(r.RemoteAddr, "unauthenticated", username)
                http.Error(w, "unauthenticated", http.StatusUnauthorized)
                return
        }
+       auther, ok := passwords[username]
+       if !ok || !auther.Auth(password) {
+               log.Println(r.RemoteAddr, "unauthenticated", username)
+               http.Error(w, "unauthenticated", http.StatusUnauthorized)
+               return
+       }
+
+       // Form parsing
        var err error
        if err = r.ParseMultipartForm(1 << 20); err != nil {
                http.Error(w, err.Error(), http.StatusBadRequest)
                return
        }
+       pkgNames, exists := r.MultipartForm.Value["name"]
+       if !exists || len(pkgNames) != 1 {
+               http.Error(w, "single name is expected in request", http.StatusBadRequest)
+               return
+       }
+       dir := normalizationRe.ReplaceAllString(pkgNames[0], "-")
+       dirPath := filepath.Join(*root, dir)
+       var digestExpected []byte
+       if digestExpectedHex, exists := r.MultipartForm.Value["sha256_digest"]; exists {
+               digestExpected, err = hex.DecodeString(digestExpectedHex[0])
+               if err != nil {
+                       http.Error(w, "bad sha256_digest: "+err.Error(), http.StatusBadRequest)
+                       return
+               }
+       }
+       gpgSigsExpected := make(map[string]struct{})
+
+       // Checking is it internal package
+       if _, err = os.Stat(filepath.Join(dirPath, InternalFlag)); err != nil {
+               log.Println(r.RemoteAddr, "non-internal package", dir)
+               http.Error(w, "unknown internal package", http.StatusUnauthorized)
+               return
+       }
+
        for _, file := range r.MultipartForm.File["content"] {
                filename := file.Filename
-               log.Println(r.RemoteAddr, "upload", filename, "by", username)
-               dir := filename[:strings.LastIndex(filename, "-")]
-               dirPath := filepath.Join(*root, dir)
+               gpgSigsExpected[filename+GPGSigExt] = struct{}{}
+               log.Println(r.RemoteAddr, "put", filename, "by", username)
                path := filepath.Join(dirPath, filename)
                if _, err = os.Stat(path); err == nil {
                        log.Println(r.RemoteAddr, "already exists", filename)
-                       http.Error(w, "Already exists", http.StatusBadRequest)
+                       http.Error(w, "already exists", http.StatusBadRequest)
                        return
                }
                if !mkdirForPkg(w, r, dir) {
                        return
                }
-               internalPath := filepath.Join(dirPath, InternalFlag)
-               var dst *os.File
-               if _, err = os.Stat(internalPath); os.IsNotExist(err) {
-                       if dst, err = os.Create(internalPath); err != nil {
-                               http.Error(w, err.Error(), http.StatusInternalServerError)
-                               return
-                       }
-                       dst.Close()
-               }
                src, err := file.Open()
                defer src.Close()
                if err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return
                }
-               dst, err = ioutil.TempFile(dirPath, "")
+               dst, err := TempFile(dirPath)
                if err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return
@@ -320,15 +424,56 @@ func serveUpload(w http.ResponseWriter, r *http.Request) {
                        return
                }
                dst.Close()
+               digest := hasher.Sum(nil)
+               if digestExpected != nil {
+                       if bytes.Compare(digestExpected, digest) == 0 {
+                               log.Println(r.RemoteAddr, filename, "good checksum received")
+                       } else {
+                               log.Println(r.RemoteAddr, filename, "bad checksum received")
+                               http.Error(w, "bad checksum", http.StatusBadRequest)
+                               os.Remove(dst.Name())
+                               return
+                       }
+               }
                if err = os.Rename(dst.Name(), path); err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return
                }
-               if err = ioutil.WriteFile(
-                       path+SHA256Ext,
-                       hasher.Sum(nil),
-                       os.FileMode(0600),
-               ); err != nil {
+               if err = DirSync(dirPath); err != nil {
+                       http.Error(w, err.Error(), http.StatusInternalServerError)
+                       return
+               }
+               if err = WriteFileSync(dirPath, path+SHA256Ext, digest); err != nil {
+                       http.Error(w, err.Error(), http.StatusInternalServerError)
+                       return
+               }
+       }
+       for _, file := range r.MultipartForm.File["gpg_signature"] {
+               filename := file.Filename
+               if _, exists := gpgSigsExpected[filename]; !exists {
+                       http.Error(w, "unexpected GPG signature filename", http.StatusBadRequest)
+                       return
+               }
+               delete(gpgSigsExpected, filename)
+               log.Println(r.RemoteAddr, "put", filename, "by", username)
+               path := filepath.Join(dirPath, filename)
+               if _, err = os.Stat(path); err == nil {
+                       log.Println(r.RemoteAddr, "already exists", filename)
+                       http.Error(w, "already exists", http.StatusBadRequest)
+                       return
+               }
+               src, err := file.Open()
+               if err != nil {
+                       http.Error(w, err.Error(), http.StatusInternalServerError)
+                       return
+               }
+               sig, err := ioutil.ReadAll(src)
+               src.Close()
+               if err != nil {
+                       http.Error(w, err.Error(), http.StatusInternalServerError)
+                       return
+               }
+               if err = WriteFileSync(dirPath, path, sig); err != nil {
                        http.Error(w, err.Error(), http.StatusInternalServerError)
                        return
                }
@@ -336,15 +481,23 @@ func serveUpload(w http.ResponseWriter, r *http.Request) {
 }
 
 func handler(w http.ResponseWriter, r *http.Request) {
-       if r.Method == "GET" {
+       switch r.Method {
+       case "GET":
                var path string
                var autorefresh bool
+               var gpgUpdate bool
                if strings.HasPrefix(r.URL.Path, *norefreshURLPath) {
                        path = strings.TrimPrefix(r.URL.Path, *norefreshURLPath)
-                       autorefresh = false
-               } else {
+               } else if strings.HasPrefix(r.URL.Path, *refreshURLPath) {
                        path = strings.TrimPrefix(r.URL.Path, *refreshURLPath)
                        autorefresh = true
+               } else if strings.HasPrefix(r.URL.Path, *gpgUpdateURLPath) {
+                       path = strings.TrimPrefix(r.URL.Path, *gpgUpdateURLPath)
+                       autorefresh = true
+                       gpgUpdate = true
+               } else {
+                       http.Error(w, "unknown action", http.StatusBadRequest)
+                       return
                }
                parts := strings.Split(strings.TrimSuffix(path, "/"), "/")
                if len(parts) > 2 {
@@ -355,13 +508,15 @@ func handler(w http.ResponseWriter, r *http.Request) {
                        if parts[0] == "" {
                                listRoot(w, r)
                        } else {
-                               listDir(w, r, parts[0], autorefresh)
+                               listDir(w, r, parts[0], autorefresh, gpgUpdate)
                        }
                } else {
                        servePkg(w, r, parts[0], parts[1])
                }
-       } else if r.Method == "POST" {
+       case "POST":
                serveUpload(w, r)
+       default:
+               http.Error(w, "unknown action", http.StatusBadRequest)
        }
 }
 
@@ -425,19 +580,58 @@ func main() {
                }
                return
        }
-       passwd, err := ioutil.ReadFile(*passwdPath)
+       if *passwdCheck {
+               refreshPasswd()
+               return
+       }
+       if (*tlsCert != "" && *tlsKey == "") || (*tlsCert == "" && *tlsKey != "") {
+               log.Fatalln("Both -tls-cert and -tls-key are required")
+       }
+       refreshPasswd()
+       log.Println("root:", *root, "bind:", *bind)
+
+       ln, err := net.Listen("tcp", *bind)
        if err != nil {
                log.Fatal(err)
        }
-       for _, credentials := range strings.Split(strings.TrimRight(string(passwd), "\n"), "\n") {
-               splitted := strings.Split(credentials, ":")
-               if len(splitted) != 2 {
-                       log.Fatal("Wrong auth format")
-               }
-               passwords[splitted[0]] = splitted[1]
+       ln = netutil.LimitListener(ln, *maxClients)
+       server := &http.Server{
+               ReadTimeout:  time.Minute,
+               WriteTimeout: time.Minute,
        }
-       log.Println("root:", *root, "bind:", *bind)
        http.HandleFunc(*norefreshURLPath, handler)
        http.HandleFunc(*refreshURLPath, handler)
-       log.Fatal(http.ListenAndServe(*bind, nil))
+       http.HandleFunc(*gpgUpdateURLPath, handler)
+
+       needsRefreshPasswd := make(chan os.Signal, 0)
+       needsShutdown := make(chan os.Signal, 0)
+       exitErr := make(chan error, 0)
+       signal.Notify(needsRefreshPasswd, syscall.SIGHUP)
+       signal.Notify(needsShutdown, syscall.SIGTERM, syscall.SIGINT)
+       go func() {
+               for range needsRefreshPasswd {
+                       log.Println("Refreshing passwords")
+                       refreshPasswd()
+               }
+       }()
+       go func(s *http.Server) {
+               <-needsShutdown
+               killed = true
+               log.Println("Shutting down")
+               ctx, cancel := context.WithTimeout(context.TODO(), time.Minute)
+               exitErr <- s.Shutdown(ctx)
+               cancel()
+       }(server)
+
+       if *tlsCert == "" {
+               err = server.Serve(ln)
+       } else {
+               err = server.ServeTLS(ln, *tlsCert, *tlsKey)
+       }
+       if err != http.ErrServerClosed {
+               log.Fatal(err)
+       }
+       if err := <-exitErr; err != nil {
+               log.Fatal(err)
+       }
 }