]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.regabi] cmd/compile: cleanup for concrete types - noder
authorRuss Cox <rsc@golang.org>
Thu, 10 Dec 2020 23:48:18 +0000 (18:48 -0500)
committerRuss Cox <rsc@golang.org>
Thu, 17 Dec 2020 04:43:46 +0000 (04:43 +0000)
commitbe64c8becebace2304e6c16408f6988d1da55900
treef264ce443aba3e610e19ca948de40f4540675979
parent5024396563f9f544a3c6413026cf9b302fd83709
[dev.regabi] cmd/compile: cleanup for concrete types - noder

An automated rewrite will add concrete type assertions after
a test of n.Op(), when n can be safely type-asserted
(meaning, n is not reassigned a different type, n is not reassigned
and then used outside the scope of the type assertion,
and so on).

This sequence of CLs handles the code that the automated
rewrite does not: adding specific types to function arguments,
adjusting code not to call n.Left() etc when n may have multiple
representations, and so on.

This CL focuses on noder.go.

Passes buildall w/ toolstash -cmp.

Change-Id: Ie870126b51558e83c738add8e91a2804ed6d7f92
Reviewed-on: https://go-review.googlesource.com/c/go/+/277931
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/noder.go
test/mainsig.go [new file with mode: 0644]