]> Cypherpunks.ru repositories - gostls13.git/commit
test: for issue11656 try to execute trap, not call it
authorIan Lance Taylor <iant@golang.org>
Wed, 16 Dec 2020 04:24:33 +0000 (20:24 -0800)
committerIan Lance Taylor <iant@golang.org>
Sat, 19 Dec 2020 00:20:38 +0000 (00:20 +0000)
commit55b58018f41e6de63bdaa8f3d9a284077d4e88c1
tree1402ffd77ff62403eba2e4f2b29c1471c0ed50b3
parent626cc7c02dd3a1a85d95f83e2d7e988e483e3cac
test: for issue11656 try to execute trap, not call it

The issue11656 code was using the trap instruction as a PC value,
but it is intended to call a PC value that contains the trap instruction.

It doesn't matter too much as in practice the address is not
executable anyhow. But may as well have the code act the way it
is documented to act.

Also, don't run the test with gccgo/GoLLVM, as it can't work.
The illegal instruction will have no unwind data, so the unwinder
won't be able to get past it. In other words, gccgo/GoLLVM suffer
from the exact problem that the issue describes, but it seems insoluble.

For golang/go#11656

Change-Id: Ib2e50ffc91d215fd50e78f742fafe476c92d704e
Reviewed-on: https://go-review.googlesource.com/c/go/+/278473
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
test/fixedbugs/issue11656.go