]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/go: refactor error reporting in internal/load
authorJay Conrod <jayconrod@google.com>
Fri, 11 Dec 2020 21:45:28 +0000 (16:45 -0500)
committerJay Conrod <jayconrod@google.com>
Mon, 14 Dec 2020 15:03:28 +0000 (15:03 +0000)
commit451b6b38fd3f87957c39fdb6572740f74ea27931
tree1218fb0833e2b2c8a91a89a0c481a26df9c35d33
parent0a02371b0576964e81c3b40d328db9a3ef3b031b
cmd/go: refactor error reporting in internal/load

Replaced load.PackagesForBuild with a new function,
load.CheckPackageErrors. Callers should now call PackagesAndErrors,
then CheckPackageErrors for the same functionality.

Removed load.Packages. Callers should call base.Errorf and filter the
package list as needed.

This gives callers more flexibility in handling package load errors.

For #42638

Change-Id: Id75463ba695adc1ca3f8693ceb2c8978b74a3500
Reviewed-on: https://go-review.googlesource.com/c/go/+/277354
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
src/cmd/go/internal/fix/fix.go
src/cmd/go/internal/get/get.go
src/cmd/go/internal/list/list.go
src/cmd/go/internal/load/pkg.go
src/cmd/go/internal/modget/get.go
src/cmd/go/internal/test/test.go
src/cmd/go/internal/vet/vet.go
src/cmd/go/internal/work/build.go