]> Cypherpunks.ru repositories - gostls13.git/commitdiff
net/http: fix benchmark goroutine leak
authorBrad Fitzpatrick <bradfitz@golang.org>
Sat, 8 Nov 2014 18:13:28 +0000 (15:13 -0300)
committerBrad Fitzpatrick <bradfitz@golang.org>
Sat, 8 Nov 2014 18:13:28 +0000 (15:13 -0300)
New detection because of net/http now using TestMain.

Fixes #9033

LGTM=iant
R=golang-codereviews, iant
CC=adg, golang-codereviews, rsc
https://golang.org/cl/170210043

src/net/http/serve_test.go

index bb44ac8537ab0b1fd51362376c041d98cd8be018..5e0a0053c01d842cc24039f51586941d677a889a 100644 (file)
@@ -2819,6 +2819,7 @@ func benchmarkClientServerParallel(b *testing.B, parallelism int, useTLS bool) {
                                InsecureSkipVerify: true,
                        },
                }
+               defer noVerifyTransport.CloseIdleConnections()
                client := &Client{Transport: noVerifyTransport}
                for pb.Next() {
                        res, err := client.Get(ts.URL)