]> Cypherpunks.ru repositories - gostls13.git/commitdiff
test: fix typo in escape_unsafe.go
authorMatthew Dempsky <mdempsky@google.com>
Wed, 7 Sep 2022 09:04:13 +0000 (02:04 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Wed, 7 Sep 2022 17:25:59 +0000 (17:25 +0000)
The toStringData test was meant to test reflect.StringHeader, not
reflect.SliceHeader. It's not supported to convert *string to
*reflect.SliceHeader anyway.

Change-Id: Iaa4912eafd241886c6337bd7607cdf2412a15ead
Reviewed-on: https://go-review.googlesource.com/c/go/+/428995
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
test/escape_unsafe.go

index cec6674a142374c7c9f6d9c867048f475d866ff2..56c536fdfb4c99f320b87e48fbd62c82828cfb72 100644 (file)
@@ -65,5 +65,5 @@ func toSliceData(s *[]int, p unsafe.Pointer) { // ERROR "s does not escape" "lea
 }
 
 func toStringData(s *string, p unsafe.Pointer) { // ERROR "s does not escape" "leaking param: p$"
-       (*reflect.SliceHeader)(unsafe.Pointer(s)).Data = uintptr(p)
+       (*reflect.StringHeader)(unsafe.Pointer(s)).Data = uintptr(p)
 }