tracef(CDebug, "ood: %s%s -> cached: %v", indent, tgt, ood)
return ood, nil
}
- depInfo := DepInfoCache[tgt.rel]
+ dep := DepCache[tgt.rel]
var err error
- if depInfo == nil {
- depInfo, err = depRead(tgt)
+ if dep == nil {
+ dep, err = depRead(tgt)
if err != nil {
if errors.Is(err, fs.ErrNotExist) {
if isSrc(tgt) {
return true, TgtError{tgt, ErrLine(err)}
}
}
- if DepInfoCache != nil {
- DepInfoCache[tgt.rel] = depInfo
- }
+ DepCache[tgt.rel] = dep
}
- if depInfo.build == BuildUUID {
+ if dep.build == BuildUUID {
tracef(CDebug, "ood: %s%s -> already built", indent, tgt)
OODCache[tgt.rel] = false
return false, nil
return true, nil
}
- for _, dep := range depInfo.ifcreates {
- if FileExists(dep.a) {
- tracef(CDebug, "ood: %s%s -> %s created", indent, tgt, dep)
+ for _, ifcreate := range dep.ifcreates {
+ if FileExists(ifcreate.a) {
+ tracef(CDebug, "ood: %s%s -> %s created", indent, tgt, ifcreate)
ood = true
goto Done
}
}
- for _, dep := range depInfo.ifchanges {
- tracef(CDebug, "ood: %s%s -> %s: checking", indent, tgt, dep.tgt)
- ood, cached = OODCache[dep.tgt.rel]
+ for _, ifchange := range dep.ifchanges {
+ tracef(CDebug, "ood: %s%s -> %s: checking", indent, tgt, ifchange.tgt)
+ ood, cached = OODCache[ifchange.tgt.rel]
if cached {
- tracef(CDebug, "ood: %s%s -> %s: cached: %v", indent, tgt, dep.tgt, ood)
+ tracef(CDebug, "ood: %s%s -> %s: cached: %v", indent, tgt, ifchange.tgt, ood)
if ood {
goto Done
}
continue
}
- inode, err := inodeFromFileByPath(dep.tgt.a)
+ inode, err := inodeFromFileByPath(ifchange.tgt.a)
if err != nil {
if errors.Is(err, fs.ErrNotExist) {
- tracef(CDebug, "ood: %s%s -> %s: not exists", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: not exists", indent, tgt, ifchange.tgt)
ood = true
- OODCache[dep.tgt.rel] = ood
+ OODCache[ifchange.tgt.rel] = ood
goto Done
}
return ood, TgtError{tgt, ErrLine(err)}
}
if inode.Size != dep.inode.Size {
- tracef(CDebug, "ood: %s%s -> %s: size differs", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: size differs", indent, tgt, ifchange.tgt)
ood = true
OODCache[dep.tgt.rel] = ood
goto Done
}
if InodeTrust != InodeTrustNone && inode.Equals(dep.inode) {
- tracef(CDebug, "ood: %s%s -> %s: same inode", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: same inode", indent, tgt, ifchange.tgt)
} else {
- tracef(CDebug, "ood: %s%s -> %s: inode differs", indent, tgt, dep.tgt)
- fd, err := os.Open(dep.tgt.a)
+ tracef(CDebug, "ood: %s%s -> %s: inode differs", indent, tgt, ifchange.tgt)
+ fd, err := os.Open(ifchange.tgt.a)
if err != nil {
return ood, TgtError{tgt, ErrLine(err)}
}
return ood, TgtError{tgt, ErrLine(err)}
}
if dep.hash != hsh {
- tracef(CDebug, "ood: %s%s -> %s: hash differs", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: hash differs", indent, tgt, ifchange.tgt)
ood = true
- OODCache[dep.tgt.rel] = ood
+ OODCache[ifchange.tgt.rel] = ood
goto Done
}
- tracef(CDebug, "ood: %s%s -> %s: same hash", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: same hash", indent, tgt, ifchange.tgt)
}
- if dep.tgt.rel == tgt.rel {
- tracef(CDebug, "ood: %s%s -> %s: same target", indent, tgt, dep.tgt)
+ if ifchange.tgt.rel == tgt.rel {
+ tracef(CDebug, "ood: %s%s -> %s: same target", indent, tgt, ifchange.tgt)
continue
}
- if isSrc(dep.tgt) {
- tracef(CDebug, "ood: %s%s -> %s: is source", indent, tgt, dep.tgt)
- OODCache[dep.tgt.rel] = false
+ if isSrc(ifchange.tgt) {
+ tracef(CDebug, "ood: %s%s -> %s: is source", indent, tgt, ifchange.tgt)
+ OODCache[ifchange.tgt.rel] = false
continue
}
- if _, ok := seen[dep.tgt.rel]; ok {
- tracef(CDebug, "ood: %s%s -> %s: was always built", indent, tgt, dep.tgt)
- OODCache[dep.tgt.rel] = false
+ if _, ok := seen[ifchange.tgt.rel]; ok {
+ tracef(CDebug, "ood: %s%s -> %s: was always built", indent, tgt, ifchange.tgt)
+ OODCache[ifchange.tgt.rel] = false
continue
}
- depOOD, err := isOODWithTrace(dep.tgt, level+1, seen)
+ depOOD, err := isOODWithTrace(ifchange.tgt, level+1, seen)
if err != nil {
return ood, TgtError{tgt, err}
}
if depOOD {
- tracef(CDebug, "ood: %s%s -> %s: ood", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: ood", indent, tgt, ifchange.tgt)
ood = true
goto Done
}
- tracef(CDebug, "ood: %s%s -> %s: !ood", indent, tgt, dep.tgt)
+ tracef(CDebug, "ood: %s%s -> %s: !ood", indent, tgt, ifchange.tgt)
}
Done:
return os.MkdirAll(pth, os.FileMode(0777))
}
-func isModified(depInfo *DepInfo, tgt *Tgt) (
+func isModified(dep *Dep, tgt *Tgt) (
modified bool, ourInode *Inode, hshPrev Hash, err error,
) {
- if depInfo == nil {
+ if dep == nil {
return
}
- for _, dep := range depInfo.ifchanges {
- if dep.tgt.a != tgt.a {
+ for _, ifchange := range dep.ifchanges {
+ if ifchange.tgt.a != tgt.a {
continue
}
ourInode, err = inodeFromFileByPath(tgt.a)
// It scans the whole .rec file while searching for the single target,
// but that one is always located at the very end
- depInfo, err := depRead(tgt)
+ dep, err := depRead(tgt)
if err != nil {
if errors.Is(err, fs.ErrNotExist) {
err = nil
}
// Check if it was already built in parallel
- if !forced && depInfo != nil && depInfo.build == BuildUUID {
+ if !forced && dep != nil && dep.build == BuildUUID {
lockRelease()
errs <- nil
return nil
}
// Check if target is not modified externally
- modified, inodePrev, hshPrev, err := isModified(depInfo, tgt)
+ modified, inodePrev, hshPrev, err := isModified(dep, tgt)
if err != nil {
lockRelease()
return TgtError{tgt, ErrLine(err)}
}()
return nil
}
- depInfo = nil
+ dep = nil
// Start preparing .rec
fdDep, err := tempfile(redoDir, tgt.t+DepSuffix)
err = ErrLine(err)
goto Err
}
- for _, dep := range ifchanges {
+ for _, ifchange := range ifchanges {
fields = append(fields, recfile.Field{
Name: "Ifchange",
- Value: dep,
+ Value: ifchange,
})
}
}
// Post-commit .rec sanitizing
if depInfo, err := depRead(tgt); err == nil {
ifchangeSeen := make(map[string]struct{}, len(depInfo.ifchanges))
- for _, dep := range depInfo.ifchanges {
- ifchangeSeen[dep.tgt.a] = struct{}{}
+ ifchangeSeen := make(map[string]struct{}, len(dep.ifchanges))
+ for _, ifchange := range dep.ifchanges {
+ ifchangeSeen[ifchange.tgt.a] = struct{}{}
}
- for _, dep := range depInfo.ifcreates {
- if _, exists := ifchangeSeen[dep.a]; exists {
+ for _, ifcreate := range dep.ifcreates {
+ if _, exists := ifchangeSeen[ifcreate.a]; exists {
tracef(CWarn, "simultaneous ifcreate and ifchange records: %s", tgt)
}
}