]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: restrict //go:notinheap to runtime/internal/sys
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Sun, 7 Aug 2022 18:10:18 +0000 (01:10 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Fri, 2 Sep 2022 06:22:23 +0000 (06:22 +0000)
commitec2ea40b315e8b1a3d1dc8f7987584c4e2a00ef4
tree40ef46144a0c501807e0aab04f0ec1c669ff8499
parent134cd34c07862aa8618e25d1d1279b4fd127c512
cmd/compile: restrict //go:notinheap to runtime/internal/sys

So it won't be visible outside of runtime package. There are changes to
make tests happy:

 - For test/directive*.go files, using "go:noinline" for testing misplaced
 directives instead.
 - Restrict test/fixedbugs/bug515.go for gccgo only.
 - For test/notinheap{2,3}.go, using runtime/cgo.Incomplete for marking
 the type as not-in-heap. Though it's somewhat clumsy, it's the easiest
 way to keep the test errors for not-in-heap types until we can cleanup
 further.
 - test/typeparam/mdempsky/11.go is about defined type in user code marked
 as go:notinheap, which can't happen after this CL, though.

Fixes #46731

Change-Id: I869f5b2230c8a2a363feeec042e7723bbc416e8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/421882
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Joedian Reid <joedian@golang.org>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/noder/noder.go
test/directive.go
test/directive2.go
test/fixedbugs/bug515.go
test/notinheap2.go
test/notinheap3.go
test/typeparam/mdempsky/11.go [deleted file]