]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: fix conditional select rule
authorKeith Randall <khr@golang.org>
Fri, 9 Dec 2022 18:55:28 +0000 (10:55 -0800)
committerGopher Robot <gobot@golang.org>
Fri, 9 Dec 2022 21:38:33 +0000 (21:38 +0000)
commite8f78cb60caab4f7ca8d0f4c424f14cc74ab49a4
tree52de0cc42869d1c08391330c10fca47d0a0c42f4
parente76c87b1915cfbd0d4f22c6401987948af18e8c5
cmd/compile: fix conditional select rule

ARM64 maintains booleans in the low byte of registers. Upper parts
of that register are junk.
This rule is using all 32 bits of a boolean-containing register, which
is wrong. Change the rule to only look at the low bit.

Fixes #57184

Change-Id: Ibbef86b2be859df3d06d993db00e1231c481c428
Reviewed-on: https://go-review.googlesource.com/c/go/+/456556
Auto-Submit: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
src/cmd/compile/internal/ssa/_gen/ARM64.rules
src/cmd/compile/internal/ssa/rewriteARM64.go
test/fixedbugs/issue57184.go [new file with mode: 0644]