]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.21] Revert "os: use handle based APIs to read directories on...
authorBryan Mills <bcmills@google.com>
Wed, 16 Aug 2023 17:23:10 +0000 (17:23 +0000)
committerCarlos Amedee <carlos@golang.org>
Wed, 23 Aug 2023 19:57:00 +0000 (19:57 +0000)
commit7c97cc7d979a918b8d60081794a846b50f6a7bbe
treeb4b86c0ae3db4cb0d118ee59890f80e1c0e056c5
parentcb6ea9499691af3277de3834dee238ee25c370d4
[release-branch.go1.21] Revert "os: use handle based APIs to read directories on windows"

This reverts CL 452995.

Reason for revert: caused os.File.ReadDir to fail on
filesystems that do not support FILE_ID_BOTH_DIR_INFO.

This is an alternative to a fix-forward change in CL 518196.
Since the original change was mostly a performance improvement,
reverting to the previous implementation seems less risky than
backporting a larger fix.

Fixes #61910
Fixes #61964

Change-Id: I60f1602b9eb6ea353e7eb23429f19f1ffa16b394
Reviewed-on: https://go-review.googlesource.com/c/go/+/520156
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
src/internal/syscall/windows/syscall_windows.go
src/internal/syscall/windows/zsyscall_windows.go
src/os/dir_windows.go
src/os/file_windows.go
src/os/os_windows_test.go
src/os/types_windows.go