]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.21] runtime/internal/wasitest: skip racy TCP echo test
authorChris O'Hara <cohara87@gmail.com>
Wed, 16 Aug 2023 01:14:53 +0000 (11:14 +1000)
committerGopher Robot <gobot@golang.org>
Fri, 18 Aug 2023 18:00:35 +0000 (18:00 +0000)
commit70aa116c4afe064254252a33beb82977ae8df087
tree02037a0302e8dfd90705dfe5b4ce7b8ed02d6564
parent31c5a236bc473756535ae163bb68242926b5eed7
[release-branch.go1.21] runtime/internal/wasitest: skip racy TCP echo test

The wasip1 TCP echo test introduced in CL 493358 has a race
condition with port selection. The test runner probes for a free
port and then asks the WASM runtime to listen on the port, which
may be taken by another process in the interim.

Due to limitations with WASI preview 1, the guest is unable to
query the port it's listening on. The test cannot ask the WASM
runtime to listen on port 0 (choose a free port) since there's
currently no way for the test to query the selected port and
connect to it.

Given the race condition is unavoidable, this test is now disabled
by default and requires opt-in via an environment variable.

This commit also eliminates the hard-coded connection timeout.

Updates #61820.
Fixes #61821.

Change-Id: I375145c1a1d03ad45c44f528da3347397e6dcb01
Reviewed-on: https://go-review.googlesource.com/c/go/+/519895
Run-TryBot: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Johan Brandhorst-Satzkorn <johan.brandhorst@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 795e779610cd1ef8ad4c137c067a23ace1190115)
Reviewed-on: https://go-review.googlesource.com/c/go/+/520955
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
src/runtime/internal/wasitest/tcpecho_test.go