]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.22] runtime: don't call traceReadCPU on the system stack
authorMichael Pratt <mpratt@google.com>
Fri, 9 Feb 2024 18:49:21 +0000 (13:49 -0500)
committerThan McIntosh <thanm@google.com>
Fri, 16 Feb 2024 15:51:46 +0000 (15:51 +0000)
commit6fbd01a71108b185479457fd9393b78bcd3dde55
treef1ec713f9ad128e219f964288e88f0a6a92e1148
parentd6a271939f3321aad5c3c5c3a9e34641c26400d3
[release-branch.go1.22] runtime: don't call traceReadCPU on the system stack

traceReadCPU calls profBuf.read, which does a raceacquire. g0 does not
have a race context, so this crashes when running on the system stack.

We could borrow a race context, but it is simpler to just move
traceReadCPU off of the system stack.

For #65607.
Fixes #65644.

Change-Id: I335155b96d683aebb92b2f4e1eea063dd139f2d5
Reviewed-on: https://go-review.googlesource.com/c/go/+/562996
Auto-Submit: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 9fa153b729969855fcb694e12c16e20b1407ed9c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/562559
src/runtime/trace2.go
src/runtime/trace2cpu.go