]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.20] runtime: set raceignore to zero when starting a new goroutine
authorJelle van den Hooff <jelle@vandenhooff.name>
Thu, 22 Jun 2023 01:28:05 +0000 (18:28 -0700)
committerCarlos Amedee <carlos@golang.org>
Thu, 29 Jun 2023 15:53:20 +0000 (15:53 +0000)
commit4db13d762ba3f3487677087a3c5a6221b4c3bd8f
treedca6b8d8c361e16c25a6d888f369fa3987e335a5
parent08a58dd8b6337c9bac93face4c386a918a3dd97b
[release-branch.go1.20] runtime: set raceignore to zero when starting a new goroutine

When reusing a g struct the runtime did not reset
g.raceignore. Initialize raceignore to zero when initially
setting racectx.

A goroutine can end with a non-zero raceignore if it exits
after calling runtime.RaceDisable without a matching
runtime.RaceEnable. If that goroutine's g is later reused
the race detector is in a weird state: the underlying
g.racectx is active, yet g.raceignore is non-zero, and
raceacquire/racerelease which check g.raceignore become
no-ops. This causes the race detector to report races when
there are none.

For #60934
Fixes #60949

Change-Id: Ib8e412f11badbaf69a480f03740da70891f4093f
Reviewed-on: https://go-review.googlesource.com/c/go/+/505055
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 48dbb6227acf3ebc8ac21924567aa2b6d5064915)
Reviewed-on: https://go-review.googlesource.com/c/go/+/505676
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
src/runtime/proc.go
src/runtime/race/testdata/mop_test.go