]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.22] cmd/compile: don't assume args are always zero-extended
authorKeith Randall <khr@golang.org>
Tue, 12 Mar 2024 19:56:03 +0000 (12:56 -0700)
committerThan McIntosh <thanm@google.com>
Wed, 27 Mar 2024 18:49:49 +0000 (18:49 +0000)
commit2c6d106541c1976c52f0c835ce1edbf5ac06b2f2
treec25cfd213feaa83710975ae609166916ccca47f2
parent46587483e30188ce485097cdeb48a4d1e0c8a445
[release-branch.go1.22] cmd/compile: don't assume args are always zero-extended

On amd64, we always zero-extend when loading arguments from the stack.
On arm64, we extend based on the type. This causes problems with
zeroUpper*Bits, which reports the top bits are zero when they aren't.

Fix it to use the type to decide if the top bits are really zero.

For tests, only f32 currently fails on arm64. Added other tests
just for future-proofing.

Fixes #66076

Change-Id: I2f13fb47198e139ef13c9a34eb1edc932eea3ee3
Reviewed-on: https://go-review.googlesource.com/c/go/+/571135
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 6bf8b76b95b22e3a7fbcd7cb95bfdb3f42bba60a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/573395
Reviewed-by: Cherry Mui <cherryyz@google.com>
src/cmd/compile/internal/ssa/rewrite.go
test/fixedbugs/issue66066b.go [new file with mode: 0644]