]> Cypherpunks.ru repositories - gostls13.git/commit
runtime/pprof: fix generics function names
authorTolya Korniltsev <korniltsev.anatoly@gmail.com>
Mon, 4 Dec 2023 10:53:29 +0000 (17:53 +0700)
committerCherry Mui <cherryyz@google.com>
Mon, 11 Dec 2023 17:49:10 +0000 (17:49 +0000)
commit20a03fc7130d8d99b513071c7e413b436ea649a2
tree33b60a38349e98b75c5e30e456942f18ae082a3a
parent052d402985816c1fc0f07424e53eaace3fa5e408
runtime/pprof: fix generics function names

profileBuilder is using Frame->Function as key for checking if we already
emitted a function. However for generics functions it has dots there [...],
so sometimes for different functions with different generics types,
the profileBuilder emits wrong functions.

Fixes #64528

Change-Id: I8b39245e0b18f4288ce758c912c6748f87cba39a
Reviewed-on: https://go-review.googlesource.com/c/go/+/546815
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
src/runtime/pprof/proto.go
src/runtime/pprof/protomem_test.go