]> Cypherpunks.ru repositories - gostls13.git/commit
net/http/cgi: in TestCopyError, check for a Handler.ServeHTTP goroutine instead of...
authorBryan C. Mills <bcmills@google.com>
Thu, 4 Jan 2024 16:41:54 +0000 (11:41 -0500)
committerGopher Robot <gobot@golang.org>
Thu, 4 Jan 2024 20:40:52 +0000 (20:40 +0000)
commit1e07c144c3e43d95b0c21fdc73c520fe809d7f51
tree0b42cc2a557cbe181b59351629df0bbc00ab8620
parent15dcdeb5aacb4503e3d053f198bd4669d5cec2aa
net/http/cgi: in TestCopyError, check for a Handler.ServeHTTP goroutine instead of a running PID

Previously, the test could fail spuriously if the CGI process's PID
happened to be reused in between checks. That sort of reuse is highly
unlikely on platforms that cycle through the PID space sequentially
(such as Linux), but plausible on platforms that use randomized PIDs
(such as OpenBSD).

Also unskip the test on Windows, since it no longer relies on being
able to send signal 0 to an arbitrary PID.

Also change the expected failure mode of the test to a timeout instead
of a call to t.Fatalf, so that on failure we get a useful goroutine
dump for debugging instead of a non-actionable failure message.

Fixes #57369 (maybe).

Change-Id: Ib7e3fff556450b48cb5e6ea120fdf4d53547479b
Reviewed-on: https://go-review.googlesource.com/c/go/+/554075
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
src/net/http/cgi/host_test.go
src/net/http/cgi/plan9_test.go [deleted file]
src/net/http/cgi/posix_test.go [deleted file]