]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: fix findIndVar so it does not match disjointed loop headers
authorJorropo <jorropo.pgm@gmail.com>
Sun, 5 Nov 2023 21:40:01 +0000 (22:40 +0100)
committerKeith Randall <khr@golang.org>
Tue, 7 Nov 2023 17:37:47 +0000 (17:37 +0000)
commit8b4e1259d0e82c8fe38a1456f997a4e9d63573a2
tree98fb60da5ea399c5558cf5c391e33dada8606ba3
parent0ccbf6306c8cac2b6f68ea6e8b098bb72b53473f
cmd/compile: fix findIndVar so it does not match disjointed loop headers

Fix #63955

parseIndVar, prove and maybe more are on the assumption that the loop header
is a single block. This can be wrong, ensure we don't match theses cases we
don't know how to handle.

In the future we could update them so that they know how to handle such cases
but theses cases seems rare so I don't think the value would be really high.
We could also run a loop canonicalization pass first which could handle this.

The repro case looks weird because I massaged it so it would crash with the
previous compiler.

Change-Id: I4aa8afae9e90a17fa1085832250fc1139c97faa6
Reviewed-on: https://go-review.googlesource.com/c/go/+/539977
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
src/cmd/compile/internal/ssa/loopbce.go
test/fixedbugs/issue63955.go [new file with mode: 0644]