]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: fix ICE with parenthesized builtin calls
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Sat, 7 Oct 2023 15:54:50 +0000 (22:54 +0700)
committerGopher Robot <gobot@golang.org>
Sun, 8 Oct 2023 23:15:25 +0000 (23:15 +0000)
commit2744155d369ca838be57d1eba90c3c6bfc4a3b30
tree4159545d62473e270db7a856f711c96ca695a1ba
parentf711892a8a4978b76a8fedecbd6fb7820736e145
cmd/compile: fix ICE with parenthesized builtin calls

CL 419456 starts using lookupObj to find types2.Object associated with
builtin functions. However, the new code does not un-parenthesized the
callee expression, causing an ICE because of nil obj returned.

Un-parenthesizing the callee expression fixes the problem.

Fixes #63436

Change-Id: Iebb4fbc08575e7d0b1dbd026c98e8f949ca16460
Reviewed-on: https://go-review.googlesource.com/c/go/+/533476
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/noder/writer.go
test/fixedbugs/issue63436.go [new file with mode: 0644]