]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: suppress details error for invalid variadic argument type
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Tue, 29 Jun 2021 03:11:31 +0000 (10:11 +0700)
committerCuong Manh Le <cuong.manhle.vn@gmail.com>
Tue, 29 Jun 2021 04:38:12 +0000 (04:38 +0000)
commitfd4b587da3f9a2bde193a5b9fd2ba96667e08f2d
treeb0b03165d51185dc962d9d99defd41c4a3a151ae
parente2e05af6e189131162b533184eb04de5d597d544
cmd/compile: suppress details error for invalid variadic argument type

CL 255241 made error message involving variadic calls clearer. To do it,
we added a check that the type of variadic argument must be a slice.
That's why the compiler crashes for invalid variadic argument type.

Instead, we can just omit the details error message, and report not
enough arguments error, which matches the behavior of go/types and types2.

Fixes #46957

Change-Id: I638d7e8f031f0ee344d5d802104fd93a60aae00a
Reviewed-on: https://go-review.googlesource.com/c/go/+/331569
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/typecheck/typecheck.go
test/fixedbugs/issue46957.go [new file with mode: 0644]