]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: fix late expand_calls leaf type for OpStructSelect/OpArraySelect
authorCuong Manh Le <cuong.manhle.vn@gmail.com>
Thu, 7 Jan 2021 14:45:00 +0000 (21:45 +0700)
committerAustin Clements <austin@google.com>
Thu, 7 Jan 2021 19:31:03 +0000 (19:31 +0000)
commitfa90aaca7d523eaf81c02b48a412cad4ebc57817
tree598c6ea1c6ab7ccd723f7be50e35aab63419ca49
parent7cee66d4cb6e726c6c37798583ac0b86c8743f82
cmd/compile: fix late expand_calls leaf type for OpStructSelect/OpArraySelect

For the example in #43551, before late call expansion, the OpArg type is
decomposed to int64. But the late call expansion is currently decompose
it to "x.Key" instead.

This CL make expand_calls decompose further for struct { 1-field type }
and array [1]elem.

This matches the previous rules for early decompose args:

(StructSelect (StructMake1 x)) => x
(ArraySelect (ArrayMake1 x)) => x

Fixes #43551

Change-Id: I2f1ebe18cb81cb967f494331c3d237535d2859e7
Reviewed-on: https://go-review.googlesource.com/c/go/+/282332
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
src/cmd/compile/internal/ssa/expand_calls.go
test/fixedbugs/issue43551.dir/a.go [new file with mode: 0644]
test/fixedbugs/issue43551.dir/b.go [new file with mode: 0644]
test/fixedbugs/issue43551.go [new file with mode: 0644]