]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.typeparams] go/types: add tests from dev.go2go
authorRob Findley <rfindley@google.com>
Tue, 12 Jan 2021 14:20:22 +0000 (09:20 -0500)
committerRobert Findley <rfindley@google.com>
Wed, 20 Jan 2021 15:51:34 +0000 (15:51 +0000)
commitfa01ade41e1632dbb8e1b06ff1e6565e8900fb38
tree12828dcaa39e1c580a472446d39838411c35dd68
parent734cb8be0a05f6dba241a14f94a1d238a41d4ded
[dev.typeparams] go/types: add tests from dev.go2go

Add tests from the dev.go2go branch, modified to eliminate support for
parenthesized type embedding and method type parameters. For the most
part these tests were made to pass via the fixes from preceding CLs in
this stack.

While integrating support for type parameters with the changes to
go/types in master, a decision was made to temporarily use an error code
of 0 for new error messages. Now that these messages are actually
emitted during checking of test packages, it is a test failure for them
to have an error code of 0. To satisfy the test, create a new temporary
error code '_Todo', which represents an error code that has not yet been
assigned. _Todo is added only where it was necessary to make tests pass:
many error codes were left as 0, meaning we don't have any tests that
produce them. This marker may help us produce more comprehensive tests
in the future.

Finally, each package checked by testDir was made into a subtest, for
the ease of running individual packages while debugging test failures.
This seemed worth keeping.

Change-Id: Iba421b797e9fb11af664a73902f67d6c4f30ecad
Reviewed-on: https://go-review.googlesource.com/c/go/+/283854
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
Trust: Robert Griesemer <gri@golang.org>
Trust: Robert Findley <rfindley@google.com>
48 files changed:
src/go/types/assignments.go
src/go/types/builtins.go
src/go/types/call.go
src/go/types/check_test.go
src/go/types/decl.go
src/go/types/errorcodes.go
src/go/types/examples/functions.go2 [new file with mode: 0644]
src/go/types/examples/methods.go2 [new file with mode: 0644]
src/go/types/examples/types.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39634.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39664.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39680.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39693.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39699.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39711.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39723.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39725.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39754.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39755.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39768.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39938.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39948.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39976.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue39982.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue40038.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue40056.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue40057.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue40301.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue40684.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue41124.go2 [new file with mode: 0644]
src/go/types/fixedbugs/issue42758.go2 [new file with mode: 0644]
src/go/types/infer.go
src/go/types/resolver.go
src/go/types/subst.go
src/go/types/testdata/builtins.go2 [new file with mode: 0644]
src/go/types/testdata/chans.go2 [new file with mode: 0644]
src/go/types/testdata/issues.go2 [new file with mode: 0644]
src/go/types/testdata/linalg.go2 [new file with mode: 0644]
src/go/types/testdata/map.go2 [new file with mode: 0644]
src/go/types/testdata/map2.go2 [new file with mode: 0644]
src/go/types/testdata/slices.go2 [new file with mode: 0644]
src/go/types/testdata/tinference.go2 [new file with mode: 0644]
src/go/types/testdata/tmp.go2 [new file with mode: 0644]
src/go/types/testdata/todos.go2 [new file with mode: 0644]
src/go/types/testdata/typeinst.go2 [new file with mode: 0644]
src/go/types/testdata/typeinst2.go2 [new file with mode: 0644]
src/go/types/testdata/typeparams.go2 [new file with mode: 0644]
src/go/types/typexpr.go