]> Cypherpunks.ru repositories - gostls13.git/commit
internal/poll: netpollcheckerr before sendfile
authorWei Fu <fuweid89@gmail.com>
Sun, 24 Jan 2021 10:21:06 +0000 (18:21 +0800)
committerEmmanuel Odeke <emmanuel@orijtech.com>
Tue, 16 Feb 2021 11:01:41 +0000 (11:01 +0000)
commitf0d23c9dbb2142b975fa8fb13a57213d0c15bdd1
tree2c50526cb4184ebaeead6d48a5fa83daa7b7c68a
parent0cb3415154ff354b42db1d65073e9be71abcc970
internal/poll: netpollcheckerr before sendfile

In net/http package, the ServeContent/ServeFile doesn't check the I/O
timeout error from chunkWriter or *net.TCPConn, which means that both
HTTP status and headers might be missing when WriteTimeout happens. If
the poll.SendFile() doesn't check the *poll.FD state before sending
data, the client will only receive the response body with status and
report "malformed http response/status code".

This patch is to enable netpollcheckerr before sendfile, which should
align with normal *poll.FD.Write() and Splice().

Fixes #43822

Change-Id: I32517e3f261bab883a58b577b813ef189214b954
Reviewed-on: https://go-review.googlesource.com/c/go/+/285914
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Emmanuel Odeke <emmanuel@orijtech.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Emmanuel Odeke <emmanuel@orijtech.com>
src/internal/poll/sendfile_bsd.go
src/internal/poll/sendfile_linux.go
src/internal/poll/sendfile_solaris.go
src/net/sendfile_test.go