]> Cypherpunks.ru repositories - gostls13.git/commit
runtime: use inlined function name for traceback elision
authorAustin Clements <austin@google.com>
Fri, 20 Nov 2020 22:32:46 +0000 (17:32 -0500)
committerAustin Clements <austin@google.com>
Tue, 24 Nov 2020 21:47:44 +0000 (21:47 +0000)
commite8de596f04d0ea7fb6fb68b036760bf088a9c6c2
treeac9399d5206140e2a46ef66b41715e42b3ab198a
parentba2adc21e8c416c47dec5fbce76286758f15b177
runtime: use inlined function name for traceback elision

Currently, gentraceback decides which frames to print or elide when
unwinding inlined frames using only the name of the outermost
function. If the outermost function should be elided, then inlined
functions will also be elided, even if they shouldn't be.

This happens in practice in at least one situation. As of CL 258938,
exported Go functions (and functions they call) can now be inlined
into the generated _cgoexp_HASH_FN function. The runtime elides
_cgoexp_HASH_FN from tracebacks because it doesn't contain a ".".
Because of this bug, it also elides anything that was inlined into it.

This CL fixes this by synthesizing a funcInfo for the inlined
functions to pass to showframe.

Fixes #42754.

Change-Id: Ie6c663a4a1ac7f0d4beb1aa60bc26fc8cddd0f9d
Reviewed-on: https://go-review.googlesource.com/c/go/+/272131
Trust: Austin Clements <austin@google.com>
Run-TryBot: Austin Clements <austin@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/runtime/crash_cgo_test.go
src/runtime/stack_test.go
src/runtime/testdata/testprogcgo/traceback.go
src/runtime/testdata/testprogcgo/traceback_c.c
src/runtime/traceback.go