]> Cypherpunks.ru repositories - gostls13.git/commit
syscall: do not overflow key memory in GetQueuedCompletionStatus
authorJason A. Donenfeld <Jason@zx2c4.com>
Tue, 23 Feb 2021 12:29:40 +0000 (13:29 +0100)
committerJason A. Donenfeld <Jason@zx2c4.com>
Wed, 24 Feb 2021 18:03:45 +0000 (18:03 +0000)
commitdc4698f52b5ad3f0251e0cc25bc7ffbd10e23f2c
tree025bcafe1a653a76400fd7aa851ad57c49b38078
parent7a2f3273c5598bf53e37d0c8a4cb8a8caf7c4ca4
syscall: do not overflow key memory in GetQueuedCompletionStatus

The third argument to GetQueuedCompletionStatus is a pointer to a
uintptr, not a uint32. Users of this functions have therefore been
corrupting their memory every time they used it. Either that memory
corruption was silent (dangerous), or their programs didn't work so they
chose a different API to use.

Fixes #44538.

RELNOTES=yes

Change-Id: Idf48d4c712d13da29791e9a460159255f963105b
Reviewed-on: https://go-review.googlesource.com/c/go/+/295371
Trust: Jason A. Donenfeld <Jason@zx2c4.com>
Run-TryBot: Jason A. Donenfeld <Jason@zx2c4.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
api/except.txt
src/syscall/syscall_windows.go
src/syscall/zsyscall_windows.go