]> Cypherpunks.ru repositories - gostls13.git/commit
[release-branch.go1.9] cmd/compile: omit ICE diagnostics after normal error messages
authorMatthew Dempsky <mdempsky@google.com>
Fri, 13 Oct 2017 21:47:45 +0000 (14:47 -0700)
committerRuss Cox <rsc@golang.org>
Wed, 25 Oct 2017 20:23:36 +0000 (20:23 +0000)
commitd487b15a61eee87c304277842a4624dca0c6bddd
tree5ff402ac21c24a91e0e833b98b9cf046c610e9df
parentfd17253587862248ee9a30a89e59db2fa9b77d1d
[release-branch.go1.9] cmd/compile: omit ICE diagnostics after normal error messages

After we detect errors, the AST is in a precarious state and more
likely to trip useless ICE failures. Instead let the user fix any
existing errors and see if the ICE persists.  This makes Fatalf more
consistent with how panics are handled by hidePanic.

While here, also fix detection for release versions: release version
strings begin with "go" ("go1.8", "go1.9.1", etc), not "release".

Fixes #22252.

Change-Id: I1c400af62fb49dd979b96e1bf0fb295a81c8b336
Reviewed-on: https://go-review.googlesource.com/70850
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
Reviewed-on: https://go-review.googlesource.com/70985
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/subr.go