]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/link: exit before Asmb2 if error
authorCherry Zhang <cherryyz@google.com>
Tue, 19 Jan 2021 16:02:10 +0000 (11:02 -0500)
committerCherry Zhang <cherryyz@google.com>
Tue, 19 Jan 2021 17:33:33 +0000 (17:33 +0000)
commitccb2e906882e45fe2d22c31049185208adbfb62e
tree1e4870e69cbc7a01081669414ae091978d0a79b5
parentca5774a5a533ce26ed64010fcc98f258e5bb0cc1
cmd/link: exit before Asmb2 if error

If there are already errors emitted, don't run the Asmb2 pass
and just exit. At the point of Asmb2 relocations are already
resolved and errors should have been reported, if any. Asmb2 is
unlikely to emit additional useful users errors. Instead, the
invalid input may cause inconsistencies and crash the linker, or
it may emit some internal errors which are more confusing than
helpful. Exit on error before Asmb2.

Fixes #43748.

Change-Id: Icf6e27f2eef5b6259e921ec0e64bebad5dd805f8
Reviewed-on: https://go-review.googlesource.com/c/go/+/284576
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/link/internal/ld/main.go