]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: change riscv64 Eq32/Neq32 to zero extend before subtraction
authorJoel Sing <joel@sing.id.au>
Mon, 30 Nov 2020 12:47:27 +0000 (23:47 +1100)
committerJoel Sing <joel@sing.id.au>
Tue, 23 Feb 2021 18:39:53 +0000 (18:39 +0000)
commitc584f42dcf43351e4cd1e5df22a063f020c00777
tree2de9c5e4654cd9a9b8357054fb673caff770006e
parent080119799bb9cbace0d20bcc671497a53e3ec14e
cmd/compile: change riscv64 Eq32/Neq32 to zero extend before subtraction

As done with other equality tests, zero extend before subtraction rather than
after (or in this case, at the same time). While at face value this appears to
require more instructions, in reality it allows for most sign extensions to
be completely eliminated due to correctly typed loads. Existing optimisations
(such as subtraction of zero) then become more effective.

This removes more than 10,000 instructions from the Go binary and in particular,
a writeBarrier check only requires three instructions (AUIPC, LWU, BNEZ) instead
of the current four (AUIPC, LWU, NEGW, BNEZ).

Change-Id: I7afdc1921c4916ddbd414c3b3f5c2089107ec016
Reviewed-on: https://go-review.googlesource.com/c/go/+/274066
Trust: Joel Sing <joel@sing.id.au>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
src/cmd/compile/internal/ssa/gen/RISCV64.rules
src/cmd/compile/internal/ssa/rewriteRISCV64.go