]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: preserve statements better in expandCalls
authorDavid Chase <drchase@google.com>
Mon, 23 Aug 2021 21:19:34 +0000 (17:19 -0400)
committerDavid Chase <drchase@google.com>
Thu, 16 Sep 2021 19:38:19 +0000 (19:38 +0000)
commitbcdc61d830be61fd5f371f4eb9c345f8dc9ada55
tree2efee14136fcc047d8f5373695f625d88bb4c5f6
parent48e2b1ea91171f4fcb56cc521368969e586f033f
cmd/compile: preserve statements better in expandCalls

Arg/Load/Dereference rewriting was not using the best Pos for
translated values.  I also investigated whether OpCopy processing
was losing statements, and though they flood the debugging output,
doing the "obvious" thing of moving statement marks from copi-er to
copy-ee actually makes the resulting binary score slightly worse on
statement-boundary measures.
(for -N -l, 0.9994 vs 0.9995 from "nostmt -c sqle.test")

Fixes #47793.

Change-Id: I65cb878d0e5a3ceb5da4ef679020ca5f40e9b02b
Reviewed-on: https://go-review.googlesource.com/c/go/+/344769
Trust: David Chase <drchase@google.com>
Run-TryBot: David Chase <drchase@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/compile/internal/ssa/expand_calls.go
src/cmd/compile/internal/ssa/value.go