]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/compile: fix transform.AssignOp to deal with tricky case
authorDan Scales <danscales@google.com>
Mon, 20 Sep 2021 00:17:31 +0000 (17:17 -0700)
committerDan Scales <danscales@google.com>
Mon, 20 Sep 2021 17:44:56 +0000 (17:44 +0000)
commitb6dddaccd7e8c9c6768943918d03f455385294b9
tree19972f9126f606ffc25c1619ca8f9900c8025ea0
parent9e60c371473ff15eb4b13981721b29f62e1d862c
cmd/compile: fix transform.AssignOp to deal with tricky case

When going to dictionary formats derived from the function
instantiations, I had broken out noder.Assignop() to deal specially with
shape types, but didn't quite get the tricky case right. We still need
to allow conversion between shape types, but if the destination is an
interface, we need to use CONVIFACE rather than CONVNOP.

Fixes #48453.

Change-Id: I8c4b39c2e628172ac34f493f1dd682cbac1e55ae
Reviewed-on: https://go-review.googlesource.com/c/go/+/350949
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
src/cmd/compile/internal/noder/transform.go
test/typeparam/issue48453.go [new file with mode: 0644]