]> Cypherpunks.ru repositories - gostls13.git/commit
runtime/pprof: expect tests to pass on macOS
authorRuss Cox <rsc@golang.org>
Mon, 15 Feb 2021 22:02:30 +0000 (17:02 -0500)
committerRuss Cox <rsc@golang.org>
Fri, 19 Feb 2021 00:41:28 +0000 (00:41 +0000)
commitb445d6ea34661328a7310beda285c64d6823624d
treeb3cdb1d93e3f6c7b6ee1f671fb63606ffc74cafd
parentb110a43628526787f73db44e11829520d92e5b2b
runtime/pprof: expect tests to pass on macOS

macOS tests have been disabled since CL 12429045 (Aug 2013).
At the time, macOS required a kernel patch to get a working profiler
(https://research.swtch.com/macpprof), which we didn't want
to require, of course.

macOS has improved - it no longer requires the kernel patch - but
we never updated the list of exceptions.

As far as I can tell, the builders have no problem passing the pprof test now.
(It is possible that the iOS builders have trouble, but that is now a different GOOS.)

Remove the exception for macOS. The test should now pass.

Fixes #6047.

Change-Id: Iab49036cacc1025e56f515bd19d084390c2f5357
Reviewed-on: https://go-review.googlesource.com/c/go/+/292229
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
src/runtime/pprof/pprof_test.go