]> Cypherpunks.ru repositories - gostls13.git/commit
testing/race: fixing intermittent test failure
authorDaniel S. Fava <danielsfava@gmail.com>
Fri, 12 Feb 2021 08:54:50 +0000 (09:54 +0100)
committerBryan C. Mills <bcmills@google.com>
Tue, 23 Feb 2021 22:14:38 +0000 (22:14 +0000)
commitaaed6cbced238030053df4e54f676a1d59df89d7
treee3d848e2bdc08ec0e7d106ed7b7c383dceccc04b
parentfbed561f8a596ddbd2bb599a17ea3c6e0b223602
testing/race: fixing intermittent test failure

Test NoRaceMutexPureHappensBefore in runtime/race/testdata/mutex_test.go
expects the second spawned goroutine to run after the first.  The test
attempts to force this scheduling with a 10 millisecond wait.  Following
a suggestion by Bryan Mills, we force this scheduling using a shared
variable whose access take place within the existing mutex.

Fixes #35745.

Change-Id: Ib23ec51492ecfeed4752e020401dd25755a669ed
Reviewed-on: https://go-review.googlesource.com/c/go/+/291292
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
src/runtime/race/testdata/mutex_test.go