]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/go,cmd/link: do not check for staleness in most tests
authorBryan C. Mills <bcmills@google.com>
Tue, 25 May 2021 16:21:11 +0000 (12:21 -0400)
committerBryan C. Mills <bcmills@google.com>
Thu, 27 May 2021 14:03:15 +0000 (14:03 +0000)
commit9bc52686da81b515cf3ad654dfb1a536fabceafa
treecf2b8345d64e6d725f2828592de0ca5959c5037e
parent6ff0ae2aa4fdb9c6c267efb30927e87563387c49
cmd/go,cmd/link: do not check for staleness in most tests

Instead, check that stale packages in the standard library
are not rebuilt when already present in the build cache,
and are not installed implicitly when rebuilt.

We retain the staleness checks for the runtime package in tests
involving '-i', because those are guaranteed to fail anyway if the
package is stale and the "stale" failure message is arguably clearer.
They can be removed if/when we remove the '-i' flag, but the runtime
package is less likely to become stale because it does not have cgo
dependencies.

Fixes #46347
Updates #33598
Updates #35459
Updates #41696

Change-Id: I7b0a808addd930f9f4911ff53ded62272af75a40
Reviewed-on: https://go-review.googlesource.com/c/go/+/322629
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/testdata/script/build_package_not_stale_trailing_slash.txt [deleted file]
src/cmd/go/testdata/script/cgo_stale.txt [new file with mode: 0644]
src/cmd/go/testdata/script/list_std_stale.txt [deleted file]
src/cmd/go/testdata/script/list_std_vendor.txt [new file with mode: 0644]
src/cmd/go/testdata/script/test_race_install_cgo.txt
src/cmd/go/testdata/script/toolexec.txt
src/cmd/link/dwarf_test.go