]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/internal/objfile: emit better error for Go object of a different version
authorCherry Zhang <cherryyz@google.com>
Fri, 30 Apr 2021 01:49:15 +0000 (21:49 -0400)
committerCherry Zhang <cherryyz@google.com>
Fri, 30 Apr 2021 16:53:35 +0000 (16:53 +0000)
commit89bf297b2486adaaff04be154a066ea9f5e63994
tree963fcadec69c72502ec012864304b7e78eb530d5
parenta893682d83760a9f9bb6f5d543b907ee6467cc6e
cmd/internal/objfile: emit better error for Go object of a different version

The Go object file format can change from version to version.
Tools like cmd/objdump and cmd/nm only onderstand the current
version of the object file. Currently, when it encounters an
object built with a different version of the toolchain, it emits
a generic error "unrecognized object file", which is not very
helpful for users. This CL makes it emit a clearer error. Now it
emits

objdump: open go116.o: go object of a different version: go116ld

Change-Id: I063c6078ed1da78f97cea65796779ae093a1a8cb
Reviewed-on: https://go-review.googlesource.com/c/go/+/315609
Trust: Cherry Zhang <cherryyz@google.com>
Run-TryBot: Cherry Zhang <cherryyz@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
src/cmd/internal/archive/archive.go
src/cmd/internal/objfile/objfile.go
src/cmd/objdump/objdump_test.go
src/cmd/objdump/testdata/go116.o [new file with mode: 0644]