]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.regabi] cmd/compile: fix latent import/export issue with break/continue
authorMatthew Dempsky <mdempsky@google.com>
Wed, 25 Nov 2020 22:02:46 +0000 (14:02 -0800)
committerMatthew Dempsky <mdempsky@google.com>
Wed, 25 Nov 2020 22:29:41 +0000 (22:29 +0000)
commit88e33f6ecb9ea44a464bd3863f8037bc081b2a6e
treee22aedf5a9ccbcb53f3bd13dc5531e10dfa8e055
parent40f5bc4d556a3687ad68d6a6bc074ff4d2a1d06b
[dev.regabi] cmd/compile: fix latent import/export issue with break/continue

In CL 145200, I changed OBREAK, OCONTINUE, OGOTO, and OLABEL to just
use Sym instead of Node. However, within the export data, I forgot to
update the code for OBREAK and OCONTINUE.

This isn't currently an issue because the inliner currently disallows
these anyway, but it'll be an issue in the future once we add support
for inlining them. Also, Russ independently ran into it in CL 273246.

Updates #14768.

Change-Id: I94575df59c08a750b0dce1d3ce612aba7bfeeb76
Reviewed-on: https://go-review.googlesource.com/c/go/+/273270
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
src/cmd/compile/internal/gc/iexport.go
src/cmd/compile/internal/gc/iimport.go