]> Cypherpunks.ru repositories - gostls13.git/commit
net/http: fix flaky TestDisableKeepAliveUpgrade
authorDamien Neil <dneil@google.com>
Fri, 22 Jan 2021 02:24:55 +0000 (18:24 -0800)
committerDamien Neil <dneil@google.com>
Fri, 22 Jan 2021 16:23:59 +0000 (16:23 +0000)
commit7ece3a7b17ff637755dbe9e5687af22fd5f82168
tree03b2a8fff29475ed1f1a9278eb462b69c8f2fbe2
parent50cba0506f0f979cf1a1670ffff9113a4cdb6273
net/http: fix flaky TestDisableKeepAliveUpgrade

This test hijacks a connection. It was reading from the net.Conn
returned by Hijack, not the bufio.ReadWriter, causing flaky failures
when a read-ahead byte was held in the read buffer.

Fixes #43073.

Change-Id: Ic3e7f704fba9635fd851cb3c0c0c74e312b75f6e
Reviewed-on: https://go-review.googlesource.com/c/go/+/285596
Trust: Damien Neil <dneil@google.com>
Run-TryBot: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Anmol Sethi <nhooyr@gmail.com>
src/net/http/serve_test.go