]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/link/internal/ld: deflake TestWindowsIssue36495
authorBrad Fitzpatrick <bradfitz@golang.org>
Tue, 9 Mar 2021 02:44:27 +0000 (18:44 -0800)
committerTobias Klauser <tobias.klauser@gmail.com>
Tue, 9 Mar 2021 10:12:02 +0000 (10:12 +0000)
commit762ef81a5670da99a4b060fd3afe4134c9e82017
treeb53e8b5eac64be2c780d9854420f83d4648ec9a8
parentb70a2bc9c612de35b765712bd689865f6a1716b6
cmd/link/internal/ld: deflake TestWindowsIssue36495

Over a dozen of the ld tests were missing closes. That was less
obvious before CL 299670 started using T.TempDir instead, which fails
a test when the tempdir can't be cleaned up (as it can't on Windows
when things are still open), insteading of leaving tempdirs around on
disk after the test.

Most of the missing closes were fixed in CL 299670, but the builders
helpfully pointed out that I missed at least this one.

Change-Id: I35f695bb7cbfba31e16311c5af965c148f9d7943
Reviewed-on: https://go-review.googlesource.com/c/go/+/299929
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dan Scales <danscales@google.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Trust: Dan Scales <danscales@google.com>
Trust: Alex Brainman <alex.brainman@gmail.com>
src/cmd/link/internal/ld/dwarf_test.go