]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.typeparams] runtime: fix misuse of funcPC
authorCherry Mui <cherryyz@google.com>
Fri, 21 May 2021 01:40:32 +0000 (21:40 -0400)
committerCherry Mui <cherryyz@google.com>
Fri, 21 May 2021 22:12:18 +0000 (22:12 +0000)
commit6a81e063dd0bf28d21b7085cc1d9e76eaeb78460
tree3ffe0cf53f957ddb5c7fc6666f25dd2408d4db30
parent7d928460a183f4efeed97638aa29f5f1fe74e397
[dev.typeparams] runtime: fix misuse of funcPC

funcPC expects a func value. There are places where we pass an
unsafe.Pointer, which is technically undefined.

In proc.go it is actually representing a func value, so the
expression does the right thing. Cast to a func value so it is
clearer.

In os_freebsd.go it is a raw function pointer. Using funcPC on a
raw function pointer is incorrect. Just use it directly instead.

Change-Id: I3c5d61cea08f0abf5737834b520f9f1b583c1d34
Reviewed-on: https://go-review.googlesource.com/c/go/+/321953
Trust: Cherry Mui <cherryyz@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
src/runtime/os_freebsd.go
src/runtime/proc.go