]> Cypherpunks.ru repositories - gostls13.git/commit
net: return nil UDPAddr from ReadFromUDP
authorMichael Pratt <mpratt@google.com>
Tue, 18 May 2021 16:23:56 +0000 (12:23 -0400)
committerMichael Pratt <mpratt@google.com>
Wed, 19 May 2021 13:04:45 +0000 (13:04 +0000)
commit658b5e66ecbc41a49e6fb5aa63c5d9c804cf305f
treebf88b9c689ea8fab565d284a0c58ed978c9f90f8
parent15a374d5c1336e9cc2f8b615477d5917e9477440
net: return nil UDPAddr from ReadFromUDP

In cases where the socket operation has no underlying address,
golang.org/cl/291509 unintentionally changed ReadFromUDP from return a
nil *UDPAddr to a non-nil (but zero value) *UDPAddr.

This may break callers that assume "no address" is always addr == nil,
so change it back to remain nil.

Fixes #46238

Change-Id: I8531e8fa16b853ed7560088eabda0b9e3e53f5be
Reviewed-on: https://go-review.googlesource.com/c/go/+/320909
Trust: Michael Pratt <mpratt@google.com>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
Reviewed-by: Filippo Valsorda <filippo@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
src/net/udpsock_posix.go
src/net/udpsock_test.go