]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.typeparams] cmd/compile: formalize "hidden parameters" idea
authorMatthew Dempsky <mdempsky@google.com>
Fri, 2 Jul 2021 23:29:42 +0000 (16:29 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Sat, 3 Jul 2021 10:21:47 +0000 (10:21 +0000)
commit5dac279fbdd8a4273253de98a4e44484b20bec5b
treef25e5345d2179c0fd2aa1b18d4b533d92ba4b420
parent611056ec34b0c017df4c2ea9c6ae6ff99487db27
[dev.typeparams] cmd/compile: formalize "hidden parameters" idea

This CL formalizes the closure-var trick used for method-value
wrappers to be reusable for defining other functions that take hidden
parameters via the closure-context register. In particular, it:

1. Adds a new ir.NewHiddenParam function for creating hidden
parameters.

2. Changes ir.NewClosureVar to copy Type/Typecheck from the closure
variable, so that callers can needing to manually copy these.

3. Updates existing code accordingly (i.e., method-value wrappers to
start using ir.NewHiddenParam, and closure builders to stop copying
types).

Longer term, I anticipate using this to pass dictionaries to stenciled
functions within unified IR.

Change-Id: I9da3ffdb2a26d15c6e89a21b4e080686d6dc872c
Reviewed-on: https://go-review.googlesource.com/c/go/+/332612
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
src/cmd/compile/internal/escape/call.go
src/cmd/compile/internal/escape/escape.go
src/cmd/compile/internal/escape/expr.go
src/cmd/compile/internal/escape/graph.go
src/cmd/compile/internal/ir/name.go
src/cmd/compile/internal/noder/reader.go
src/cmd/compile/internal/typecheck/iimport.go
src/cmd/compile/internal/walk/closure.go