]> Cypherpunks.ru repositories - gostls13.git/commit
cmd/go: display helpful error when module cache can't be created
authorJulie Qiu <julie@golang.org>
Wed, 24 Mar 2021 20:24:38 +0000 (16:24 -0400)
committerJulie Qiu <julie@golang.org>
Mon, 12 Apr 2021 15:51:43 +0000 (15:51 +0000)
commit51a47b7ff2934b6c28ece51f6a37dc30bd37a02d
tree10497b96739c6463f76f9fb720abcc2f0e237063
parent117b1c84d3678a586c168a5f7f2f0a750c27f0c2
cmd/go: display helpful error when module cache can't be created

Previously when the module cache specified by GOMODCACHE could not be
created an unhelpful message would be printed multiple times.

This happened because we were fetching several things in parallel then
failing to write them because we can't create the module cache.

We now check if the module cache can be created before fetching.

If not, the following message is printed:

go: could not create module cache

Fixes #45113

Change-Id: Ic9cec787411335edc7f4d0614fde7eaa8a957fb5
Reviewed-on: https://go-review.googlesource.com/c/go/+/304571
Trust: Julie Qiu <julie@golang.org>
Run-TryBot: Julie Qiu <julie@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
src/cmd/go/internal/modfetch/cache.go
src/cmd/go/testdata/script/mod_gomodcache.txt