]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.regabi] cmd/compile: cleanup for concrete types - typecheck
authorRuss Cox <rsc@golang.org>
Thu, 10 Dec 2020 23:42:42 +0000 (18:42 -0500)
committerRuss Cox <rsc@golang.org>
Thu, 17 Dec 2020 03:50:33 +0000 (03:50 +0000)
commit4ac6a6317b0e4ecbcc789ba606708ff08871a1df
tree8b3753a92a93e7e18bf4fc2d9c896b4ad912dff7
parentf6efa3d4a4a10c28d7bf13f8416022aa5fc4fa1c
[dev.regabi] cmd/compile: cleanup for concrete types - typecheck

An automated rewrite will add concrete type assertions after
a test of n.Op(), when n can be safely type-asserted
(meaning, n is not reassigned a different type, n is not reassigned
and then used outside the scope of the type assertion,
and so on).

This sequence of CLs handles the code that the automated
rewrite does not: adding specific types to function arguments,
adjusting code not to call n.Left() etc when n may have multiple
representations, and so on.

This CL focuses on typecheck.go.

Passes buildall w/ toolstash -cmp.

Change-Id: I32d1d3b813b0a088b1750c9fd28cd858ed813f1d
Reviewed-on: https://go-review.googlesource.com/c/go/+/277920
Trust: Russ Cox <rsc@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/gc/typecheck.go