]> Cypherpunks.ru repositories - gostls13.git/commit
[dev.unified] cmd/compile/internal/noder: remove needType logic
authorMatthew Dempsky <mdempsky@google.com>
Tue, 21 Jun 2022 14:56:25 +0000 (07:56 -0700)
committerMatthew Dempsky <mdempsky@google.com>
Thu, 23 Jun 2022 21:54:51 +0000 (21:54 +0000)
commit46b01ec667c05fb8eb8f382b173e126282acd80c
tree51579f6fe2765fe89b978cede1ea84410059f782
parenta3e474f86746924022c92f66bfb465f7ad6ea8a5
[dev.unified] cmd/compile/internal/noder: remove needType logic

This logic is a holdover from very early on when it wasn't as clear
how we would handle dictionary entries for derived types, particularly
ones that are emitted during desugaring.

However, the current plan is to explicitly wire runtime type info
through IR nodes, so we can drop this logic.

Notably, the "needed" bit is exposed to the go/types importers, so
removing it would break the x/tools importer. To minimize churn for
now, we can just leave the bools in place.

Change-Id: I374927887d4f3d6d711d3355607849a407d717c4
Reviewed-on: https://go-review.googlesource.com/c/go/+/413367
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
src/cmd/compile/internal/noder/writer.go